Skip to content

fix: Use simple query and chunk in PHP to delete inactive sessions - #4549

Merged
juliusknorr merged 1 commit into
mainfrom
bugfix/noid/mysql8
Jul 19, 2023
Merged

fix: Use simple query and chunk in PHP to delete inactive sessions#4549
juliusknorr merged 1 commit into
mainfrom
bugfix/noid/mysql8

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jul 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

reverts #4339 and #4539 except for the added tests and moves to plain PHP chunking to avoid issues with MySQL 8

Easiest to review in split mode https://github.com/nextcloud/text/pull/4549/files?diff=split

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress

cypressBot commented Jul 19, 2023•
edited
Loading

Copy link
Copy Markdown

1 failed and 1 flaky tests on run #11169 ↗︎

114820Flakiness1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix: Use simple query and chunk in PHP to delete inactive sessions
Project: TextCommit:0f8e4419d6
Status: FailedDuration: 20:07 💡
Started: Jul 19, 2023 1:26 PMEnded: Jul 19, 2023 1:46 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorrjuliusknorr changed the title bugfix/noid/mysql8fix: Use simple query and chunk in PHP to delete inactive sessionsJul 19, 2023
@juliusknorrjuliusknorr added this to the Nextcloud 28 milestone Jul 19, 2023
@juliusknorr

juliusknorr commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@juliusknorr

juliusknorr commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@juliusknorr

juliusknorr commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

Cherry-picked to #4548 to validate the tests passing also on CI for MySQL 8

@juliusknorr
juliusknorr marked this pull request as ready for review July 19, 2023 12:40
mejo-
mejo- requested changes Jul 19, 2023
View reviewed changes
Comment threadlib/Db/SessionMapper.php Outdated
@juliusknorr
fix: Use simple query and chunk in PHP
0f8e441
reverts #4339 and #4539 except for the added tests and moves to plain
PHP chunking to avoid issues with MySQL 8
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorr requested a review from mejo-July 19, 2023 13:09
@juliusknorr

juliusknorr commented Jul 19, 2023

Copy link
Copy Markdown
MemberAuthor

Failure known and unreated (fixed with #4550)

@juliusknorr
juliusknorr merged commit c5dfd46 into mainJul 19, 2023
@juliusknorr
juliusknorr deleted the bugfix/noid/mysql8 branch July 19, 2023 13:51
This was referenced Jul 19, 2023
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@mejo-mejo-mejo- approved these changes
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to reviewbugSomething isn't workinghighregression

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@nickvergessen@mejo-