Skip to content

fix(NodeViewContent): Don't set white-space: pre-wrap - #4624

Closed
mejo- wants to merge 2 commits into
mainfrom
fix/nodeviewcontent
Closed

fix(NodeViewContent): Don't set white-space: pre-wrap#4624
mejo- wants to merge 2 commits into
mainfrom
fix/nodeviewcontent

Conversation

@mejo-

@mejo-mejo- commented Aug 2, 2023

Copy link
Copy Markdown
Member

Fixes: #4602

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-mejo- added bug Something isn't working 3. to review labels Aug 2, 2023
@mejo-mejo- added this to the Nextcloud 27.1.0 milestone Aug 2, 2023
Fixes: #4602
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the fix/nodeviewcontent branch from 2d67ef9 to 4b2be5cCompareAugust 2, 2023 15:29
@cypress

cypressBot commented Aug 2, 2023

Copy link
Copy Markdown

1 failed and 1 flaky tests on run #11478 ↗︎

114820Flakiness1

Details:

fix(NodeViewContent): Don't set `white-space: pre-wrap`
Project: TextCommit:f319eaf9ec
Status: FailedDuration: 03:56 💡
Started: Aug 2, 2023 4:38 PMEnded: Aug 2, 2023 4:42 PM
Failed cypress/e2e/MenuBar.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Test the rich text editor menu bar > word count > single word OutputScreenshots
Flakiness cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Sync service provider > recovers from a dropped message OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-

mejo- commented Aug 2, 2023

Copy link
Copy Markdown
MemberAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-

mejo- commented Aug 2, 2023

Copy link
Copy Markdown
MemberAuthor

Unfortunately this seems to break pasting plaintext content with linebreaks.

@mejo-
mejo- marked this pull request as draft August 2, 2023 16:39
@skjnldsvskjnldsv mentioned this pull request Aug 8, 2023
2 tasks
@skjnldsvskjnldsv mentioned this pull request Aug 16, 2023
7 tasks
@blizzzblizzz mentioned this pull request Sep 20, 2023
4 tasks
@blizzzblizzz mentioned this pull request Sep 26, 2023
@blizzzblizzz mentioned this pull request Oct 9, 2023
@mejo-

Copy link
Copy Markdown
MemberAuthor

We have a proper fix for this now in #4872.

@mejo-mejo- closed this Oct 24, 2023
@mejo-
mejo- deleted the fix/nodeviewcontent branch October 24, 2023 13:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pasting paragraphs sometimes adds unexpected linebreaks

5 participants

@mejo-@juliusknorr@blizzz@skjnldsv@nextcloud-command