Uh oh!
There was an error while loading. Please reload this page.
fix(paste): collapse whitespace before pasting - #4872
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
mejo-
commented
Oct 19, 2023
Member
Probably also will fix #4768. |
mejo-
reviewed
Oct 19, 2023
Uh oh!
There was an error while loading. Please reload this page.
mejo-
approved these changes
Oct 19, 2023
mejo-
left a comment
Member
There was a problem hiding this comment.
Max gave me a walkthrough through the code. Very clean and thorough solution, thanks a lot! Only nitpicking comments.
By default html does not display whitespace but text does. Remove newlines when pasting to ensure consistency with the previous display. Keep the newlines when they are also displayed in the source. * Resolves#4602. Signed-off-by: Max <max@nextcloud.com> Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
fix/4602-remove-newlines-in-pastes
branch
from
October 24, 2023 13:25
6d3fd63 to
a958e8aComparemejo-
commented
Oct 24, 2023
Member
/backport to stable27 |
mejo-
commented
Oct 24, 2023
Member
/backport to stable26 |
2 tasks
mejo-
commented
Oct 24, 2023
Member
Cypress failures are unrelated. |
This was referenced Oct 24, 2023
ChristophWurst
commented
Oct 24, 2023
Member
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
By default html does not display whitespace but text does. Remove newlines when pasting to ensure consistency with the previous display.
Keep the newlines when they are also displayed in the source.
white-space: pre-wrap#4624🖼️ Screenshots
🏚️ Before
🏡 After
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)