Skip to content

[stable27] ci(cypress): Fix selectors for new file picker - #4680

Merged
juliusknorr merged 6 commits into
stable27from
cypress/filepicker-27
Aug 18, 2023
Merged

[stable27] ci(cypress): Fix selectors for new file picker#4680
juliusknorr merged 6 commits into
stable27from
cypress/filepicker-27

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 14, 2023

Copy link
Copy Markdown
Member

Fix CI after new file picker got merged

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorrjuliusknorr changed the title ci(cypress): Fix selectors for new file picker[stable27] ci(cypress): Fix selectors for new file pickerAug 14, 2023
@cypress

cypressBot commented Aug 14, 2023

Copy link
Copy Markdown

Passing run #11755 ↗︎

014820Flakiness0

Details:

[stable27] ci(cypress): Fix selectors for new file picker
Project: TextCommit:cbfc41677e
Status: PassedDuration: 04:32 💡
Started: Aug 18, 2023 4:42 PMEnded: Aug 18, 2023 4:46 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
juliusknorrforce-pushed the cypress/filepicker-27 branch 5 times, most recently from 52c0205 to cda7916CompareAugust 18, 2023 12:34
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this.
💚

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr
juliusknorr merged commit 46dbe16 into stable27Aug 18, 2023
@juliusknorr
juliusknorr deleted the cypress/filepicker-27 branch August 18, 2023 17:02
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to main

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Needs a forward port once the file picker is also merged on server master

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to main failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout main
git pull origin main
# Create the new backport branch
git checkout -b fix/foo-main
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-main

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorrjuliusknorr mentioned this pull request Aug 21, 2023
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@max-nextcloud@nextcloud-command