Skip to content

[stable31] Disable attachment upload on federated shares - #7183

Merged
mejo- merged 3 commits into
stable31from
backport/7154/stable31
May 19, 2025
Merged

[stable31] Disable attachment upload on federated shares#7183
mejo- merged 3 commits into
stable31from
backport/7154/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented May 6, 2025

Copy link
Copy Markdown

Backport of #7154

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbotBot requested review from max-nextcloud and mejo-May 6, 2025 09:55
@backportbotbackportbotBot added this to the Nextcloud 31.0.5 milestone May 6, 2025
@max-nextcloud
max-nextcloudforce-pushed the backport/7154/stable31 branch from c91e7a4 to 29562f4CompareMay 13, 2025 08:58
@max-nextcloud
max-nextcloud marked this pull request as ready for review May 13, 2025 08:58
Files without an owner such as federated shares
cannot receive attachments
as the attachment would need to be stored in the owners user folder.
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
max-nextcloudforce-pushed the backport/7154/stable31 branch from 29562f4 to 8dd8788CompareMay 13, 2025 08:58
@max-nextcloud

Copy link
Copy Markdown
Collaborator

/backport to stable30

@codecov

codecovBot commented May 13, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.05%. Comparing base (d9264c5) to head (05d2c75).
Report is 7 commits behind head on stable31.

Files with missing linesPatch %Lines
src/components/Menu/ActionAttachmentUpload.vue15.38%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## stable31 #7183 +/- ##
============================================
+ Coverage 51.57% 52.05% +0.47% 
============================================
Files 286 286 Lines 41026 41054 +28 Branches 793 815 +22 ============================================
+ Hits 21160 21370 +210 + Misses 19746 19568 -178 + Partials 120 116 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
max-nextcloudforce-pushed the backport/7154/stable31 branch from 8dd8788 to 05d2c75CompareMay 13, 2025 09:03
@mejo-
mejo- merged commit ea99f22 into stable31May 19, 2025
@mejo-
mejo- deleted the backport/7154/stable31 branch May 19, 2025 07:17
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2025
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@max-nextcloud@blizzz@mejo-