Uh oh!
There was an error while loading. Please reload this page.
[stable30] Disable attachment upload on federated shares - #7235
Merged
Conversation
mejo-force-pushed
the
backport/7183/stable30
branch
from
May 19, 2025 10:26
236af19 to
4732e32Comparemejo-
commented
May 19, 2025
Member
@max-nextcloud it seems like the node test are failing because |
max-nextcloud
commented
May 20, 2025
Collaborator
That makes sense - let's dump the tests then. This was helpful for development and to prevent regressions. But any new code that passes these tests on stable31 is very unlikely to break this when backported. |
Files without an owner such as federated shares cannot receive attachments as the attachment would need to be stored in the owners user folder. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
backport/7183/stable30
branch
from
May 20, 2025 10:11
4732e32 to
664edb8CompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## stable30 #7235 +/- ##
=========================================
Coverage 53.68% 53.68% =========================================
Files 116 116 Lines 2578 2578 Branches 527 527 =========================================
Hits 1384 1384 Misses 1066 1066 Partials 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
approved these changes
May 20, 2025
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #7183