Skip to content

fix(links): Use custom link handling only for text-only links - #7385

Merged
max-nextcloud merged 1 commit into
mainfrom
fix/preview_links
Jul 3, 2025
Merged

fix(links): Use custom link handling only for text-only links#7385
max-nextcloud merged 1 commit into
mainfrom
fix/preview_links

Conversation

@mejo-

@mejo-mejo- commented Jul 2, 2025

Copy link
Copy Markdown
Member

All other links inside the editor (like previews via reference widgets or links in mermaid diagrams) should be treated the standard way.

Fixes: #7384

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-mejo- self-assigned this Jul 2, 2025
@mejo-
mejo- requested a review from max-nextcloud as a code ownerJuly 2, 2025 15:54
@mejo-mejo- added bug Something isn't working 3. to review feature: links labels Jul 2, 2025
@mejo-
mejo-force-pushed the fix/preview_links branch from 31b9e61 to 365fe40CompareJuly 2, 2025 15:55
@mejo-

mejo- commented Jul 2, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@mejo-

mejo- commented Jul 2, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@mejo-
mejo-force-pushed the fix/preview_links branch from 365fe40 to 431aedfCompareJuly 2, 2025 16:11
All other links inside the editor (like previews via reference widgets
or links in mermaid diagrams) should be treated the standard way.
Fixes: #7384
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the fix/preview_links branch from 431aedf to e955bfdCompareJuly 2, 2025 16:17
@codecov

codecovBot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (e522c75) to head (e955bfd).
Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
src/plugins/links.js9.09%10 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #7385 +/- ##
==========================================
+ Coverage 52.67% 59.57% +6.90% 
==========================================
Files 487 486 -1 Lines 42237 37342 -4895 Branches 1098 1097 -1 ==========================================
Hits 22247 22247 + Misses 19883 14989 -4894 + Partials 107 106 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense code-wise. Tested that it does not break previews in collectives. They still open in the same tab.

@max-nextcloud
max-nextcloud merged commit f4b9ef4 into mainJul 3, 2025
64 of 66 checks passed
@max-nextcloud
max-nextcloud deleted the fix/preview_links branch July 3, 2025 06:00
@max-nextcloud

Copy link
Copy Markdown
Collaborator

/backport to stable31

@backportbot

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/7385/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick e955bfdc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7385/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/7385/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingfeature: links

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links won't open

2 participants

@mejo-@max-nextcloud