Skip to content

[stable31] fix(links): Use custom link handling only for text-only links - #7387

Merged
max-nextcloud merged 1 commit into
stable31from
backport/7385/stable31
Jul 3, 2025
Merged

[stable31] fix(links): Use custom link handling only for text-only links#7387
max-nextcloud merged 1 commit into
stable31from
backport/7385/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 3, 2025

Copy link
Copy Markdown

Backport of #7385

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added bug Something isn't working 3. to review feature: links labels Jul 3, 2025
@backportbotbackportbotBot added this to the Nextcloud 31.0.7 milestone Jul 3, 2025
@backportbot
backportbotBotforce-pushed the backport/7385/stable31 branch from d6e2673 to c70d3d3CompareJuly 3, 2025 06:01
All other links inside the editor (like previews via reference widgets
or links in mermaid diagrams) should be treated the standard way.
Fixes: #7384
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
max-nextcloudforce-pushed the backport/7385/stable31 branch from c70d3d3 to 78eae86CompareJuly 3, 2025 06:14
@max-nextcloud
max-nextcloud marked this pull request as ready for review July 3, 2025 06:18
@codecov

codecovBot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.54%. Comparing base (62c37ad) to head (78eae86).
Report is 3 commits behind head on stable31.

Files with missing linesPatch %Lines
src/plugins/links.js9.09%10 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## stable31 #7387 +/- ##
============================================
+ Coverage 51.57% 58.54% +6.96% 
============================================
Files 290 289 -1 Lines 41125 36232 -4893 Branches 840 839 -1 ============================================
Hits 21211 21211 + Misses 19794 14902 -4892 + Partials 120 119 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud
max-nextcloud merged commit 56c8b60 into stable31Jul 3, 2025
65 of 66 checks passed
@max-nextcloud
max-nextcloud deleted the backport/7385/stable31 branch July 3, 2025 06:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingfeature: links

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-nextcloud@mejo-