Skip to content

fix(assistant): move assistant button to menubar - #7883

Merged
mejo- merged 3 commits into
mainfrom
fix/assistant_menubar
Nov 4, 2025
Merged

fix(assistant): move assistant button to menubar#7883
mejo- merged 3 commits into
mainfrom
fix/assistant_menubar

Conversation

@mejo-

@mejo-mejo- commented Nov 1, 2025

Copy link
Copy Markdown
Member

Also removes superfluous extra translate button from menubar.

🖼️ Screenshots

🏚️ Before🏡 After
imageimage
imageimage

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo-mejo- self-assigned this Nov 1, 2025
@mejo-mejo- added bug Something isn't working 3. to review ux labels Nov 1, 2025
@mejo-mejo- changed the title fix(assistant): move assitant button to menubarfix(assistant): move assistant button to menubarNov 1, 2025
@codecov

codecovBot commented Nov 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.96%. Comparing base (0bd9ce6) to head (9aa0a44).
⚠️ Report is 11 commits behind head on main.

Files with missing linesPatch %Lines
src/components/Menu/AssistantAction.vue0.00%4 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #7883 +/- ##
==========================================
- Coverage 47.06% 45.96% -1.11% 
==========================================
Files 141 141 Lines 3886 3964 +78 Branches 733 747 +14 ==========================================
- Hits 1829 1822 -7 - Misses 1763 1838 +75 - Partials 294 304 +10 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo-
mejo-force-pushed the fix/assistant_menubar branch 2 times, most recently from 9f77cdc to 0f337d5CompareNovember 3, 2025 08:35
* Fixes: #7453
* Fixes: #7272
* Fixes: #7817
Also removes superfluous extra translate button from menubar.
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the fix/assistant_menubar branch from 0f337d5 to 92d0806CompareNovember 3, 2025 09:50
So far, we got all entries with priority smaller or equals to
`iconsLimit`. Since entries can be conditional (emoji picker,
assistant), this led to less entries in `visiblEntries` than wanted.
Since we still want to keep the order of entries from `entries.js` we
cannot just sort them by priority and need this slightly more complex
filter logic.
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the fix/assistant_menubar branch from 73f5fd7 to 9aa0a44CompareNovember 3, 2025 11:52
@benjaminfrueh
benjaminfrueh self-requested a review November 3, 2025 16:51
@mejo-
mejo- merged commit 029a596 into mainNov 4, 2025
74 of 78 checks passed
@mejo-
mejo- deleted the fix/assistant_menubar branch November 4, 2025 14:51
@mejo-

mejo- commented Nov 5, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingux

Projects

Archived in project

3 participants

@mejo-@benjaminfrueh@juliusknorr