Skip to content

[stable32] fix(assistant): move assistant button to menubar - #7891

Merged
mejo- merged 3 commits into
stable32from
backport/7883/stable32
Nov 5, 2025
Merged

[stable32] fix(assistant): move assistant button to menubar#7891
mejo- merged 3 commits into
stable32from
backport/7883/stable32

Conversation

@backportbot

@backportbotbackportbotBot commented Nov 5, 2025

Copy link
Copy Markdown

Backport of #7883

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added bug Something isn't working 3. to review ux labels Nov 5, 2025
@backportbotbackportbotBot added this to the Nextcloud 32.0.2 milestone Nov 5, 2025
* Fixes: #7453
* Fixes: #7272
* Fixes: #7817
Also removes superfluous extra translate button from menubar.
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
So far, we got all entries with priority smaller or equals to
`iconsLimit`. Since entries can be conditional (emoji picker,
assistant), this led to less entries in `visiblEntries` than wanted.
Since we still want to keep the order of entries from `entries.js` we
cannot just sort them by priority and need this slightly more complex
filter logic.
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the backport/7883/stable32 branch from 23a6e11 to 7f0a0e9CompareNovember 5, 2025 08:30
@mejo-
mejo- marked this pull request as ready for review November 5, 2025 08:30
@codecov

codecovBot commented Nov 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.93%. Comparing base (b906ac9) to head (7f0a0e9).
⚠️ Report is 4 commits behind head on stable32.

Files with missing linesPatch %Lines
src/components/Menu/AssistantAction.vue55.00%9 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## stable32 #7891 +/- ##
============================================
+ Coverage 52.89% 58.93% +6.03% 
============================================
Files 500 498 -2 Lines 43390 38126 -5264 Branches 1065 1062 -3 ============================================
- Hits 22951 22468 -483 + Misses 20330 15550 -4780 + Partials 109 108 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo-
mejo- merged commit e504719 into stable32Nov 5, 2025
67 of 70 checks passed
@mejo-
mejo- deleted the backport/7883/stable32 branch November 5, 2025 12:09
@blizzzblizzz mentioned this pull request Nov 10, 2025
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mejo-