Uh oh!
There was an error while loading. Please reload this page.
doc: add Working Groups document - #24
Conversation
ashleygwilliams
commented
Dec 19, 2015
ashleygwilliams
commented
Dec 19, 2015
once this is merged, i'm happy to make a PR with the inclusivity WG info. i felt it was important to keep the threads separate. |
mikeal
commented
Dec 19, 2015
+1 to commit as-is (which is a replica of the one in |
ashleygwilliams
commented
Dec 19, 2015
agreed @mikeal, having done the copy pasta, i have some ideas for improvements 😄 |
ashleygwilliams
commented
Dec 19, 2015
actually @mikeal -- thoughts on me moving the mentor working group into this doc, and then linking to this from the readme? |
4925c00 to
fd691c0Comparemikeal
commented
Dec 19, 2015
@ashleygwilliams hold off for now because there's a mentorship element of the incubator, which is also under the TSC, and I'd like to avoid confusion. |
ashleygwilliams
commented
Dec 19, 2015
ugh ok one sec. |
jasnell
commented
Dec 19, 2015
Given that this would be the first TSC WG, I would like to get it on the
|
c5a35d6 to
ea5df75Compareashleygwilliams
commented
Dec 19, 2015
@jasnell when is the next meeting? |
jasnell
commented
Dec 19, 2015
That I don't know for certain. If it's too far out, then I'd like to make
|
mikeal
commented
Dec 19, 2015
If there are no objections I don't see the point in deferring until the next meeting. Keep in mind that the ability to have Working Groups under the TSC was already part of the Project Lifecycle that passed, this just establishes where to put them. |
jasnell
commented
Dec 19, 2015
I don't anticipate objections but a couple days for discussion ought to be
|
There was a problem hiding this comment.
Rather than including this here, the existing code of conduct from the nodejs/node repo should be referenced. The version included here is out of date.
There was a problem hiding this comment.
this is the exact code of conduct from the other document. changes should be proposed in other PRs i think.
There was a problem hiding this comment.
If by "other document" you mean https://github.com/nodejs/node/blob/master/CODE_OF_CONDUCT.md, then, no, they are not the same.
Either way, a pointer to the other document would be better than copying the text.
There was a problem hiding this comment.
Ah! I see... when the CoC was updated in the standalone document I missed updating the Working Groups document at the same time. I'll get a PR opened to correct that. Thanks @ashleygwilliams!
jasnell
commented
Dec 20, 2015
Posted a few comments I'd like to see addressed before landing. |
ashleygwilliams
commented
Dec 20, 2015
hey @jasnell i totally agree on a lot of your comments but those would also be changes to the nodejs/node doucment. i believe those changes should be proposed in another PR after this is merged. this was suggested by @mikeal in one of the first comments: #24 (comment) this PR is really just to establish a document to put things in. if we want to change the document, we'll need to make those changes one both documents, so i think it is out of the scope of this PR. |
jasnell
commented
Dec 28, 2015
A couple of nits that ought to be addressed but generally LGTM |
jasnell
commented
Jan 8, 2016
@ashleygwilliams ... ping... the TSC discussed this yesterday and would like to get this landed but there are a few nits that need to be fixed first. Specifically:
Once those changes are made I can get this landed. Thank you! |
ashleygwilliams
commented
Jan 8, 2016
awesome! thanks for the really clear+specific update @jasnell -- i can get this done at some point today hopefully :) |
jasnell
commented
Jan 8, 2016
Awesome, just mention me when it's updated and I'll get it landed today. |
57c9403 to
cf30a73Compareashleygwilliams
commented
Jan 8, 2016
ok @jasnell ready for review! after review i'll squash (did separate commits so it'd be easier to review) |
jasnell
commented
Jan 8, 2016
LGTM |
- create working groups doc - add link to wg doc in readme
f063784 to
66557a9Compareashleygwilliams
commented
Jan 8, 2016
ready for merge @jasnell ! |
- create working groups doc - add link to wg doc in readme PR-URL: #24 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Jan 8, 2016
Landed in 5eb8ab0 |
this document adds a
WORKING_GROUPS.mdfile based entirely on the file that lives in nodejs/node as per @mikeal's suggestion on the PR to add the nodejs/inclusivity working groupthe only change to this doc from the nodejs/node one is that i referenced it in this one.