Uh oh!
There was an error while loading. Please reload this page.
jenkins: add http-parser.jenkinsfile - #922
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
rvagg
commented
Oct 17, 2017
How does the Rest of it looks pretty good, I'm +1 on getting this hooked up into Jenkins. Great work! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gibfahn
commented
Oct 23, 2017
@jkrems would appreciate a review from you if you have the time. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
maclover7
commented
Oct 31, 2017
@jkrems thank you for the neat git clone/checkout snippet!! @gibfahn updated PR, for right now +1 on keep the shared bits inside this pipeline file, and then as we need to we can extract out to helper/utility files |
maclover7
commented
Nov 6, 2017
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
maclover7
commented
Nov 7, 2017
@gibfahn updated, would you be able to create the http parser job on Jenkins? |
gibfahn
commented
Nov 7, 2017
Job: https://ci.nodejs.org/view/All/job/node-test-http-parser/ Can you move this into |
PR-URL: #922 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
maclover7
commented
Nov 7, 2017
Fixed upon landing, landed in d094879b513beebff067617b08dc3f2b06364746. |
This is a simple prototype to try out Jenkins pipelines (ref #838) in a low-ish risk way. This commit introduces
jenkins/http-parser.jenkinsfile, a pipeline to run tests for nodejs/http-parser -- http-parser is not part of ci.nodejs.org as of right now. I setup a Jenkins instance locally and was using it to test drive out the pipeline file. I can confirm it works correctly for PR 388 as well as master (if you leave PR_ID blank).Before this can go out, there are a few things (and probably more that I didn't think of) that will be need to tested/done:
agent/labelconfig options.Some pipelines stuff is a little quirky, but I think this is a decent POC -- please let me know your thoughts :)
cc @refack@gibfahn