Skip to content

jenkins: send statuses for non-nodejs/node repos - #978

Closed
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-multiple-repos
Closed

jenkins: send statuses for non-nodejs/node repos#978
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-multiple-repos

Conversation

@maclover7

@maclover7maclover7 commented Nov 5, 2017

Copy link
Copy Markdown
Contributor

Related #922. At some point, the CITGM builds can be updated to use this as well.

gibfahn

This comment was marked as off-topic.

Sign in to view

refack

This comment was marked as off-topic.

Sign in to view

@refack

refack commented Nov 5, 2017

Copy link
Copy Markdown
Contributor

And node-gyp (which I just noticed today don't receive statuses).
We'll need to do some changes in the bot for libuv to receive these as well.

@gibfahn

gibfahn commented Nov 5, 2017

Copy link
Copy Markdown
Member

We'll need to do some changes in the bot for libuv to receive these as well.

If we're going to do libuv, we'd probably need to add an org parameter to this PR (or change REPO to accept nodejs/node. But I assume that'd require changes to github-bot as well.

@refack

refack commented Nov 5, 2017

Copy link
Copy Markdown
Contributor

But I assume that'd require changes to github-bot as well.

  1. Need to verify the bot has permissions to the libuv org.
  2. We could do a simpler hack in the bot so that libuv == libuv/libuv

@maclover7

maclover7 commented Nov 5, 2017

Copy link
Copy Markdown
ContributorAuthor

Going to land this for now-- as this job continues to be used by others, we can keep making changes as necessary :)

maclover7 added a commit that referenced this pull request Nov 6, 2017
@maclover7
jenkins: send statuses for non-nodejs/node repos
6b050dc
PR-URL: #978
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@maclover7

maclover7 commented Nov 6, 2017

Copy link
Copy Markdown
ContributorAuthor

Landed in 6b050dc

@maclover7
maclover7 deleted the jm-multiple-repos branch November 6, 2017 00:29
@maclover7maclover7 self-assigned this Feb 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@refackrefackrefack approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@maclover7maclover7

Labels

ci-public

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maclover7@refack@gibfahn