Uh oh!
There was an error while loading. Please reload this page.
warn for 50 < title <= 72 - #18
Conversation
The PR has landed. CI is not working because this repo has been moved, but this does not pass the tests locally. Can you fix the lint errors and the test? Thanks! @refack |
refack
commented
Nov 12, 2017
BTW: Just checked travis, it is working, it just can't update it's status: https://travis-ci.org/nodejs/core-validate-commit/builds/300959458 Tests are WIP |
joyeecheung
commented
Nov 12, 2017
@refack Yes, I think I need to add this repo to nodejs/github-bot#156 |
refack
commented
Nov 13, 2017
joyeecheung
commented
Jan 15, 2018
Ping @evanlucas this looks ready to land, I've bumped into the 72 chars limit quite a bit lately when landing commits |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
commented
Jan 15, 2018
@evanlucas Thanks, I've taken the liberty to merge this. Can you release a new version? |
evanlucas
commented
Jan 15, 2018
Published in v3.5.0. Thanks! Also, @joyeecheung do you need publish access to this package? If so, I can add you :] |
joyeecheung
commented
Jan 15, 2018
@evanlucas Yeah I would be happy to do the releases! Thanks! |
evanlucas
commented
Jan 15, 2018
@joyeecheung what is your npm username? |
joyeecheung
commented
Jan 15, 2018
@evanlucas Same as my github handle: https://www.npmjs.com/~joyeecheung |
evanlucas
commented
Jan 15, 2018
Done. Thanks! |
if nodejs/node#16523 lands