Skip to content

remove 50 char limit on title line per new project guidelines - #22

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:50-chars
Closed

remove 50 char limit on title line per new project guidelines#22
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:50-chars

Conversation

@Trott

@TrottTrott commented Nov 2, 2017

Copy link
Copy Markdown
Member

No description provided.

joyeecheung

This comment was marked as off-topic.

Sign in to view

@joyeecheung

joyeecheung commented Nov 12, 2017

Copy link
Copy Markdown
Member

Right...there is #22

@Trott

Trott commented Nov 12, 2017

Copy link
Copy Markdown
MemberAuthor

IIUC we are not removing the limit, just relaxing it to 72chars?

@joyeecheung I had assumed the test for 72 characters that applies to other lines would apply to the title line, but now I see that is incorrect. I'll try to modify it to flag the title line too...

@Trott

Trott commented Nov 12, 2017

Copy link
Copy Markdown
MemberAuthor

Right...there is #22

@joyeecheung Did that end up in the wrong window? Was that meant to refer another issue/PR to this one?

@Trott

Trott commented Nov 12, 2017

Copy link
Copy Markdown
MemberAuthor

Oh, it looks like #18 might be a better solution?

@Trott

Trott commented Nov 12, 2017

Copy link
Copy Markdown
MemberAuthor

I'm going to close this in favor of #18 but feel free to ping or re-open if you think this might be better.

@TrottTrott closed this Nov 12, 2017
@joyeecheung

joyeecheung commented Nov 12, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@Trott Yes I meant #18...copy-pasting gone wrong 😓, sorry

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Trott@joyeecheung