Uh oh!
There was an error while loading. Please reload this page.
Added multiple versions of alpine linux - #725
Conversation
5062729 to
505ffdeCompare906baba to
b773635Compareb773635 to
76be1c7CompareSimenB
commented
May 12, 2018
I'm excited :D |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
SimenB
commented
May 13, 2018
I'm a bit worried about the build time, and how it would affect our ability to get security releases out in time |
LaurentGoderre
commented
May 13, 2018
Yeah hopefully we can get the alpine cache merged before this one. |
SimenB
commented
May 13, 2018
That won't help the build for docker hub. They might build in parallel though, so no big impact |
LaurentGoderre
commented
May 13, 2018
It would be nice if anyone could access the Travis cache so that even the hub could use it. |
SimenB
commented
May 13, 2018
Ref nodejs/security-wg#168 (comment)
I think the real solution for our speed woes is to get a prebuilt binary. |
chorrell
commented
May 14, 2018
Yeah, I agree. Is there anyone on the build group who can help push that forward? |
LaurentGoderre
commented
May 14, 2018
From what I have read, they aren't too keen on this because of the static typing which would mean they would need to track Alpine security updates. |
SimenB
commented
May 14, 2018
I think this is the most current issue: nodejs/build#1140 |
3030a2e to
24f06a6CompareLaurentGoderre
commented
May 15, 2018
Stackbrew generates: |
24f06a6 to
e514c19Comparee514c19 to
8042599Compare8042599 to
8366e9bComparechorrell
commented
May 17, 2018
Following up on @LaurentGoderre's last comment:
To me this means Alpine isn't something they are willing to support. If it's not a supported platform, maybe we shouldn't be encouraging people to use it by offering multiple versions? I don't know, I'm beginning to think this is not the best use of our time and maybe we just need to revisit upgrading the Alpine images to the latest supported version (3.7) |
LaurentGoderre
commented
May 17, 2018
This allows us to upgrade alpine versions in a less disruptive way. For example, when 3.8 comes out, we could support v3.6 for two versions, keep the default on 3.7 for two versions and then drop 3.6 and move the default to 3.8. |
chorrell
commented
May 17, 2018
Yes it would be less disruptive, but I just don't think it's that important. Based on the issues and PRs people have submitted, they seem to care more about Alpine being out of date than being able to pin to given Alpine release. I think we should just treat Alpine updates the same way we do Yarn updates and move on. I think a stronger argument can be made taking this approach with Debian and possibly ubuntu (especially given how small Bionic is now) and we wouldn't have to worry about absurd build times. |
LaurentGoderre
commented
May 17, 2018
Alright! |
LaurentGoderre
commented
May 17, 2018
@chorrell does that mean that next version of Node 6 should move to Alpine 3.7? |
chorrell
commented
May 17, 2018
Yep |
LaurentGoderre
commented
May 17, 2018
Maybe we can salvage part of this too make it easier? |
chorrell
commented
May 17, 2018
Yeah, that would be good. |
Implements #473
TODO:
alpinetag