Uh oh!
There was an error while loading. Please reload this page.
Simplify the management of alpine version - #745
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
01ec3b2 to
bf2f4a5Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bf2f4a5 to
af31d33Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chorrell
commented
May 18, 2018
Just needs a rebase to resolve the conflict. |
af31d33 to
94bd6f4CompareLaurentGoderre
commented
May 18, 2018
Ok, rebased! |
PeterDaveHello
commented
May 18, 2018
I suggest to clarify we're going to use single Alpine base image in the commit message. |
LaurentGoderre
commented
May 18, 2018
@PeterDaveHello that's already what we are doing so this is not changing. |
PeterDaveHello
commented
May 18, 2018
I know, just a suggestion that we can make the commit message more clear, not a request to change review ;) |
94bd6f4 to
06ff472CompareLaurentGoderre
commented
May 18, 2018
Done! |
PeterDaveHello
commented
May 19, 2018
Conflicts need to be solved. |
06ff472 to
da1ba4dCompareStandardizes the alpine version to use and helps upgrade the alpine version only on version update
da1ba4d to
9bd00c4CompareLaurentGoderre
commented
May 21, 2018
Done! |
chorrell
commented
May 23, 2018
there's something wrong with the updates script: [christopher:~/github/docker-node] master ± ./update.sh 10Updating version 10...sed: 1: "10/alpine/Dockerfile": invalid command code /Done!Also, it's creating a bunch of new files: [christopher:~/github/docker-node] master(+9/-9)* ± git statusOn branch masterYour branch is up to date with 'origin/master'.Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: 10/Dockerfile modified: 10/alpine/Dockerfile modified: 10/slim/Dockerfile modified: 10/stretch/DockerfileUntracked files: (use "git add <file>..." to include in what will be committed) 10/Dockerfile-e 10/alpine/Dockerfile-e 10/slim/Dockerfile-e 10/stretch/Dockerfile-eno changes added to commit (use "git add" and/or "git commit -a") |
chorrell
commented
May 23, 2018
And it's messing up the alpine Dockerfile for v10; [christopher:~/github/docker-node] master(+9/-9)* ± cat 10/alpine/Dockerfile | grep alpineFROM alpine:0.0 |
LaurentGoderre
commented
May 24, 2018
@chorrell you're running it on a Mac aren't you?? |
chorrell
commented
May 24, 2018
Yes. |
LaurentGoderre
commented
May 24, 2018
I have gnu-sed on my mac but it's possible that the new sed commands don't work in POSIX |
Salvages parts of #725