Uh oh!
There was an error while loading. Please reload this page.
Change baseimage for node:slim to stretch release - #822
Conversation
mkumatag
commented
Jul 19, 2018
/cc @PeterDaveHello |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
PeterDaveHello
commented
Jul 19, 2018
/cc @nodejs/docker |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mkumatag
commented
Jul 19, 2018
How it works? I see those 2 packages are missing, so do you want me to create a separate template called |
PeterDaveHello
commented
Jul 19, 2018
I suppose we should discuss before making changes, let's move back to the issue. |
LaurentGoderre
commented
Jul 19, 2018
I think the changes have to be made to the following file: https://github.com/nodejs/docker-node/blob/master/Dockerfile-slim.template Then the update will be picked up on next release. |
mkumatag
commented
Jul 19, 2018
@LaurentGoderre can you drop your suggestion in #821 ? |
chorrell
commented
Jul 19, 2018
Would it be better to just have a separate stretch-slim variant rather than modifying the current slim variant? I'm thinking we should treat it like we do with the default variant. |
mkumatag
commented
Aug 3, 2018
@PeterDaveHello@LaurentGoderre I just made suggested changes, PTAL and let me know if anything else is required.? |
LaurentGoderre
commented
Aug 14, 2018
@chorrell do you mean we'd have a |
chorrell
commented
Aug 14, 2018
Yeah |
kbirger
commented
Sep 4, 2018
@PeterDaveHello are your requests satisfied? Seems like this could be merged now. |
LaurentGoderre
commented
Sep 5, 2018
I opened #850 as an alternative for a smoother transition. |
LaurentGoderre
commented
Nov 29, 2018
Closing as this was addressed via #850 |
Fixes: #821