Multiple slim by LaurentGoderre · Pull Request #850 · nodejs/docker-node

LaurentGoderre · 2018-08-27T20:32:18Z

No description provided.

khasim · 2018-08-29T10:33:34Z

Hi @LaurentGoderre will this be fixed shortly, anything I can help with ?

Thanks
Khasim

LaurentGoderre · 2018-09-05T12:58:13Z

LaurentGoderre · 2018-09-05T12:59:42Z

The benefit of this is it creates the jessie-slim and stretch-slim tags and the default_variant controls the slim and the default tag. So when we switch default_variant to stretch slim will point to stretch-slim

chorrell · 2018-09-05T14:09:13Z

I'm not sure what caused this test to stall: https://travis-ci.com/nodejs/docker-node/jobs/143886958

Maybe we need to pin to a specific version on eclint?

chorrell · 2018-09-05T14:35:55Z

I restarted the test build.

chorrell · 2018-09-05T14:51:24Z

Maybe that failure was just an issue with the npm registry? Anyway, it's nice that we can restart builds now :-)

LaurentGoderre · 2018-09-05T15:22:52Z

@chorrell good catch!

LaurentGoderre · 2018-09-06T13:10:36Z

@chorrell @PeterDaveHello what do you think of my approach?

chorrell · 2018-09-06T13:46:00Z

I think I prefer separate templates. It will make the update script simpler and we can just delete the jessie template when we drop it.

yosifkit · 2018-09-11T20:36:27Z

This bit from buildpack-deps:curl works for all versions of Debian:

RUN set -ex; \
if ! command -v gpg > /dev/null; then \
apt-get update; \
apt-get install -y --no-install-recommends \
gnupg \
dirmngr \
; \
rm -rf /var/lib/apt/lists/*; \
fi

https://github.com/docker-library/buildpack-deps/blob/b955c1d33f78b7bb0abb4bebe660ab7970f7c9b8/Dockerfile-curl.template#L10-L18

LaurentGoderre · 2018-09-12T13:07:57Z

@yosifkit wow that's even cleaner!!!!

chorrell · 2018-11-21T16:34:33Z

LGTM. The only thing I’m not certain about are the architecture files

tianon · 2018-11-21T18:25:38Z

This seems all correct to me.

chorrell · 2018-11-21T18:44:15Z

Sounds like we can merge this then do the Docker Hub PR for #921

I'm still sick, will most likely be taking the rest of the day off. If someone else can pick this up, that would be great.

lag-linaro · 2018-11-22T07:10:06Z

Ok, even better now:

Yes, it's getting better.

Tags: 8.12.0-onbuild, 8.12-onbuild, 8-onbuild, carbon-onbuild
Architectures: arm32v7, amd64, i386

Why do these -onboard images not support the other architectures? Are these still built from Jessie?

(same comment for all of the other -onbuild images)

GitCommit: 526c6e6
Directory: 8/onbuild

Tags: 8.12.0-stretch-slim, 8.12-stretch-slim, 8-stretch-slim, carbon-stretch-slim, 8.12.0-slim, 8.12-slim, 8-slim, carbon-slim
Architectures: arm32v7, amd64, i386

Do you know why this doesn't support the other architectures? Are these still built from Jessie?

(same comment for all the other -slim variants)

GitCommit: ca73c15
Directory: 8/stretch-slim

Tags: 11.2.0-stretch-slim, 11.2-stretch-slim, 11-stretch-slim, stretch-slim, 11.2.0-slim, 11.2-slim, 11-slim, slim, slim

You have 2 'slim' entries in this line.

Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: ca73c15
Directory: 11/stretch-slim

LaurentGoderre · 2018-11-22T15:58:24Z

@lag-linaro the two slim was fixed. As for what architecture are supported, I just preserved what was there before.

lag-linaro · 2018-11-22T17:02:34Z

Ah, so this change doesn't update the GitCommit tags.

Is that already set as a separate piece of work?

This library file is now referencing tags which are several months old.

This misses out on the fact that the -slim and -onbuild images have been updated to Stretch and the Alpine images have been upgraded to 3.8. Making them compatible with more architectures now.

LaurentGoderre · 2018-11-22T19:46:37Z

@lag-linaro perhaps but that should be looked at in a different PR I think

lag-linaro · 2018-11-23T08:57:49Z

I'm okay with that.

In which case, if the duplicate slim issue has been resolved:

LGTM

LaurentGoderre · 2018-11-23T15:59:57Z

@SimenB want to merge?

SimenB · 2018-11-24T19:51:18Z

I'm a bit hesitant to land this before the security releases on Tuesday... Thoughts on that?

chorrell · 2018-11-24T21:14:22Z

The security update will include stretch as the new default for the slim and base image. Landing this first would give people a Jessie option for slim.

And we should do the pr for the recent update to v8.x.x before Tuesday

chorrell · 2018-11-25T15:18:22Z

Actually, I think you're right. This can wait until after the security update

LaurentGoderre · 2018-11-28T19:12:54Z

@chorrell @PeterDaveHello @SimenB rebased

SimenB

We'll still have node:10-slim right?

chorrell · 2018-11-29T14:15:43Z

Yep (via ./generate-stackbrew-library.sh):

# this file is generated via https://github.com/nodejs/docker-node/blob/fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9/generate-stackbrew-library.sh
Maintainers: The Node.js Docker Team <https://github.com/nodejs/docker-node> (@nodejs)
GitRepo: https://github.com/nodejs/docker-node.git
Tags: 8.14.0-jessie, 8.14-jessie, 8-jessie, carbon-jessie
Architectures: arm32v7, amd64, i386
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 8/jessie
Tags: 8.14.0-jessie-slim, 8.14-jessie-slim, 8-jessie-slim, carbon-jessie-slim
Architectures: arm32v7, amd64, i386
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 8/jessie-slim
Tags: 8.14.0-alpine, 8.14-alpine, 8-alpine, carbon-alpine
Architectures: arm32v6, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 8/alpine
Tags: 8.14.0-onbuild, 8.14-onbuild, 8-onbuild, carbon-onbuild
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 0aae692a71251b60c489c41b7b1f28daa05829e5
Directory: 8/onbuild
Tags: 8.14.0-stretch, 8.14-stretch, 8-stretch, carbon-stretch, 8.14.0, 8.14, 8, carbon
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 8/stretch
Tags: 8.14.0-stretch-slim, 8.14-stretch-slim, 8-stretch-slim, carbon-stretch-slim, 8.14.0-slim, 8.14-slim, 8-slim, carbon-slim
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 8/stretch-slim
Tags: 6.15.0-jessie, 6.15-jessie, 6-jessie, boron-jessie
Architectures: arm32v7, amd64, i386
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 6/jessie
Tags: 6.15.0-jessie-slim, 6.15-jessie-slim, 6-jessie-slim, boron-jessie-slim
Architectures: arm32v7, amd64, i386
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 6/jessie-slim
Tags: 6.15.0-alpine, 6.15-alpine, 6-alpine, boron-alpine
Architectures: amd64
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 6/alpine
Tags: 6.15.0-onbuild, 6.15-onbuild, 6-onbuild, boron-onbuild
Architectures: arm32v7, amd64, i386
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 6/onbuild
Tags: 6.15.0-stretch, 6.15-stretch, 6-stretch, boron-stretch, 6.15.0, 6.15, 6, boron
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 6/stretch
Tags: 6.15.0-stretch-slim, 6.15-stretch-slim, 6-stretch-slim, boron-stretch-slim, 6.15.0-slim, 6.15-slim, 6-slim, boron-slim
Architectures: arm32v7, amd64, i386
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 6/stretch-slim
Tags: 11.3.0-alpine, 11.3-alpine, 11-alpine, current-alpine, alpine
Architectures: arm32v6, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 11/alpine
Tags: 11.3.0-stretch, 11.3-stretch, 11-stretch, current-stretch, stretch, 11.3.0, 11.3, 11, current, latest
Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 11/stretch
Tags: 11.3.0-stretch-slim, 11.3-stretch-slim, 11-stretch-slim, current-stretch-slim, stretch-slim, 11.3.0-slim, 11.3-slim, 11-slim, current-slim, slim
Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 11/stretch-slim
Tags: 10.14.0-jessie, 10.14-jessie, 10-jessie, dubnium-jessie, lts-jessie
Architectures: arm32v7, amd64
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 10/jessie
Tags: 10.14.0-jessie-slim, 10.14-jessie-slim, 10-jessie-slim, dubnium-jessie-slim, lts-jessie-slim
Architectures: arm32v7, amd64
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 10/jessie-slim
Tags: 10.14.0-alpine, 10.14-alpine, 10-alpine, dubnium-alpine, lts-alpine
Architectures: arm32v6, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 10/alpine
Tags: 10.14.0-stretch, 10.14-stretch, 10-stretch, dubnium-stretch, lts-stretch, 10.14.0, 10.14, 10, dubnium, lts
Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: fd2bad889b28587d4722f69c4a51d025df2ae624
Directory: 10/stretch
Tags: 10.14.0-stretch-slim, 10.14-stretch-slim, 10-stretch-slim, dubnium-stretch-slim, lts-stretch-slim, 10.14.0-slim, 10.14-slim, 10-slim, dubnium-slim, lts-slim
Architectures: arm32v7, amd64
GitCommit: fb54d5ff5f1717b5e4f85b59b7a914c87204c7e9
Directory: 10/stretch-slim
Tags: chakracore-8.11.1, chakracore-8.11, chakracore-8
Architectures: amd64
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: chakracore/8
Tags: chakracore-10.13.0, chakracore-10.13, chakracore-10, chakracore
Architectures: amd64
GitCommit: 69c8a5f448f46f9e34d7fb577eca79ba01f6864d
Directory: chakracore/10

SimenB · 2018-11-29T14:22:10Z

docker-library/official-images#5125

See: - nodejs/docker-node#944 - https://github.com/nodejs/node/releases/tag/v10.14.1 - https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#10.14.1 Also includes: - nodejs/docker-node#942 - nodejs/docker-node#850

LaurentGoderre force-pushed the multiple-slim branch from a1de351 to 7a888d0Compare August 28, 2018 13:25

LaurentGoderre mentioned this pull request Sep 5, 2018
Change baseimage for node:slim to stretch release #822
Closed

LaurentGoderre force-pushed the multiple-slim branch 2 times, most recently from b29a16f to 9fc3dabCompare September 5, 2018 12:56

LaurentGoderre changed the title ~~WIP: Multiple slim~~Multiple slimSep 5, 2018

LaurentGoderre requested review from PeterDaveHello and chorrell September 5, 2018 12:57

This comment was marked as off-topic.
Sign in to view

LaurentGoderre force-pushed the multiple-slim branch from 9fc3dab to e58b0c0Compare September 5, 2018 15:22

LaurentGoderre force-pushed the multiple-slim branch from e58b0c0 to 204471dCompare September 5, 2018 15:38

This comment was marked as off-topic.
Sign in to view

LaurentGoderre force-pushed the multiple-slim branch 2 times, most recently from 56b248a to 26fb32fCompare September 5, 2018 17:14

This comment was marked as off-topic.
Sign in to view

LaurentGoderre force-pushed the multiple-slim branch from 26fb32f to 6d5a848Compare September 5, 2018 18:44

LaurentGoderre force-pushed the multiple-slim branch from 6d5a848 to 06e58b1Compare September 6, 2018 13:11

LaurentGoderre force-pushed the multiple-slim branch from 06e58b1 to 6dcc3b3Compare September 12, 2018 13:11

LaurentGoderre force-pushed the multiple-slim branch from 6dcc3b3 to aeced95Compare September 19, 2018 17:04

PeterDaveHello approved these changes Nov 22, 2018
View reviewed changes

chorrell mentioned this pull request Nov 22, 2018
Enable ccache for Alpine builds on Travis CI #927
Closed

SimenB approved these changes Nov 24, 2018
View reviewed changes

This was referenced Nov 28, 2018
Docker Tag Change #937
Closed
node:8-slim image is broken as on 27/11/2018 #936
Closed
Updated image to reflect changes in the template #942
Merged

LaurentGoderre added 2 commits November 28, 2018 14:05

Use the same template for debian variants
5055b15

Added support for multiple slim versions of debian
fb54d5f

LaurentGoderre force-pushed the multiple-slim branch from 1fda969 to fb54d5fCompare November 28, 2018 19:10

SimenB approved these changes Nov 29, 2018
View reviewed changes

SimenB merged commit 8c0a9f2 into nodejs:masterNov 29, 2018

SimenB mentioned this pull request Nov 29, 2018
Update node with multiple slim images docker-library/official-images#5125
Closed

LaurentGoderre deleted the multiple-slim branch November 29, 2018 16:01

chorrell mentioned this pull request Nov 29, 2018
Node: Update for Node.js v10.14.1 w/ Yarn v1.12.3 docker-library/official-images#5126
Merged

Uh oh!

Conversation

LaurentGoderre commented Aug 27, 2018

Uh oh!

khasim commented Aug 29, 2018

Uh oh!

LaurentGoderre commented Sep 5, 2018

Uh oh!

LaurentGoderre commented Sep 5, 2018

Uh oh!

chorrell commented Sep 5, 2018

Uh oh!

chorrell commented Sep 5, 2018

Uh oh!

chorrell commented Sep 5, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

LaurentGoderre commented Sep 5, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

LaurentGoderre commented Sep 6, 2018

Uh oh!

chorrell commented Sep 6, 2018

Uh oh!

yosifkit commented Sep 11, 2018

Uh oh!

LaurentGoderre commented Sep 12, 2018

Uh oh!

chorrell commented Nov 21, 2018

Uh oh!

tianon commented Nov 21, 2018

Uh oh!

chorrell commented Nov 21, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lag-linaro commented Nov 22, 2018

Uh oh!

LaurentGoderre commented Nov 22, 2018

Uh oh!

lag-linaro commented Nov 22, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LaurentGoderre commented Nov 22, 2018

Uh oh!

lag-linaro commented Nov 23, 2018

Uh oh!

LaurentGoderre commented Nov 23, 2018

Uh oh!

SimenB commented Nov 24, 2018

Uh oh!

chorrell commented Nov 24, 2018

Uh oh!

chorrell commented Nov 25, 2018

Uh oh!

LaurentGoderre commented Nov 28, 2018

Uh oh!

SimenB left a comment

Choose a reason for hiding this comment

Uh oh!

chorrell commented Nov 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB commented Nov 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

chorrell commented Nov 21, 2018•
edited
Loading

lag-linaro commented Nov 22, 2018•
edited
Loading

chorrell commented Nov 29, 2018•
edited
Loading