Uh oh!
There was an error while loading. Please reload this page.
Modules rebase - #13
Conversation
Refs: nodejs/modules#180 PR-URL: #6 Reviewed-By: Myles Borins <MylesBorins@google.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/modules#180 PR-URL: #6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/modules#180 PR-URL: #6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/modules#180 PR-URL: #6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <mylesborins@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
commented
Nov 8, 2018
CI without a rebase |
guybedford
commented
Nov 8, 2018
Nice work, could you bring node master through as a branch here so we can see the PR comparison of just our commits? |
guybedford
commented
Nov 8, 2018
(unfortunately because this is not a public fork that can't be done from GitHub compare otherwise) |
PR-URL: #6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <mylesborins@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
commented
Nov 8, 2018
@guybedford I've gone ahead and reset master against upstream and pushed the last known good version of the master branch from this repo to This PR is now showing only the changes ontop of the current upstream master |
guybedford
left a comment
There was a problem hiding this comment.
Perfect, looks good - not sure if you want to approve these?
MylesBorins
commented
Nov 8, 2018
If CI is green I'm going to go ahead and force push and land the other PRs |
MylesBorins
commented
Nov 9, 2018
updated |
Tests work on this branch locally. We are going to have to force push against master.
The conflicts were not a huge deal, mostly related to the change in the way options or retrieved