Uh oh!
There was an error while loading. Please reload this page.
travis: improve logging, handle more states, and make the retries configurable - #158
Conversation
joyeecheung
commented
Nov 16, 2017
Hmm, just looked into https://travis-ci.org/nodejs/llnode/jobs/303007637 , and I think 30min is probably a more suitable default. |
joyeecheung
commented
Nov 16, 2017
Just looked into nodejs/llnode#148 a bit, turns out we don't handle the |
phillipj
commented
Nov 16, 2017
IIRC the many retries was set after seeing how long some of the docker-node builds run. For all other projects, that many retries is way too many. If that's still the case for docker-node I don't know. |
joyeecheung
commented
Nov 17, 2017
@phillipj In that case we can probably make a per-repo map for retries and go over their recent Travis builds for a reasonable value? And fallback to a smaller default value for most repos |
joyeecheung
commented
Nov 17, 2017
@phillipj OK, I've made the configuration a map and added tests for both |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
phillipj
commented
Nov 23, 2017
You've got enough access to merge this yourself, right? ..it'll get deployed to production immediately 🚀 |
joyeecheung
commented
Nov 23, 2017
@phillipj Merged, thanks! |
This helped me when debugging the setup of node-core-utils. Also I think the number of retries is too high, 20 (10mins) should already be enough.