Skip to content

src: add total row to findjsobjects command - #148

Merged
joyeecheung merged 1 commit into
nodejs:masterfrom
mmarchini:feature/findjsobjects-totals
Nov 18, 2017
Merged

src: add total row to findjsobjects command#148
joyeecheung merged 1 commit into
nodejs:masterfrom
mmarchini:feature/findjsobjects-totals

Conversation

@mmarchini

@mmarchinimmarchini commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

Add a row with total objects count and total size to findjsobjects.

Demo:
asciicast

@joyeecheungjoyeecheung mentioned this pull request Nov 16, 2017
Merged
joyeecheung

This comment was marked as off-topic.

Sign in to view

@joyeecheung

joyeecheung commented Nov 16, 2017

Copy link
Copy Markdown
Member

BTW: the CI is half-broken right now, needs #144 and nodejs/github-bot#158 to fix that, so ignore that yellow "Some checks haven’t completed yet".

cjihrig

This comment was marked as off-topic.

Sign in to view

indutny

This comment was marked as off-topic.

Sign in to view

Matheus Marchini
src: add total row to findjsobjects command
6ef2686
Add a row with total objects count and total size to findjsobjects.
@mmarchini
mmarchiniforce-pushed the feature/findjsobjects-totals branch from 8b7ef00 to 6ef2686CompareNovember 16, 2017 18:45
indutny

This comment was marked as off-topic.

Sign in to view

@joyeecheung
joyeecheung merged commit 4aec8e6 into nodejs:masterNov 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indutnyindutnyindutny approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@cjihrigcjihrigcjihrig approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmarchini@joyeecheung@indutny@cjihrig