Uh oh!
There was an error while loading. Please reload this page.
Adding request.url for connect compatibility - #49
Conversation
mcollina
commented
Mar 23, 2017
Definitely, but would you mind adding a unit test?See https://github.com/nodejs/http2/blob/master/test/parallel/test-http2-create-client-session.js as an example of a client API. |
sebdeckers
commented
Mar 23, 2017
@mcollina I'd be happy to. Still figuring out how to efficiently develop on the Node codebase. Takes a while to recompile.
|
mcollina
commented
Mar 23, 2017
no there is not a "watch mode", but we usually just run a single unit test, so: You do not have to do It does not recompile all of it if you do not switch between branches. |
sebdeckers
commented
Mar 23, 2017
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Having the
request.urlproperty aliased torequest.pathfixes a bug with the popular connect framework. Is this acceptable as backwards compatibility or would it be API bloat?