Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

Adding request.url for connect compatibility#49

Closed
sebdeckers wants to merge 2 commits into from
Closed

Adding request.url for connect compatibility #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6122f8b
Adding request.url for connect compatibility
sebdeckers Mar 23, 2017
967a0fb
Test case for request url, path, and :path header
sebdeckers Mar 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -243,6 +243,10 @@ class Http2ServerRequest extends Readable {
return headers.get(constants.HTTP2_HEADER_SCHEME);
}

get url() {
return this.path;
}

get path() {
var stream = this[kStream];
if (!stream) return;
Expand Down
13 changes: 11 additions & 2 deletions test/parallel/test-http2-create-client-session.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,8 +6,15 @@ const h2 = require('http2');
const net = require('net');
const body =
'<html><head></head><body><h1>this is some data</h2></body></html>';
let pathname;

const server = h2.createServer();
const server = h2.createServer(common.mustCall(requestListener));

function requestListener(request, response) {
assert.equal(pathname, request.path);
assert.equal(pathname, request.url);
assert.equal(pathname, request.headers[':path']);
}

// we use the lower-level API here
server.on('stream', common.mustCall(onStream));
Expand All@@ -28,12 +35,14 @@ server.on('listening', common.mustCall(function() {
// TODO mcollina remove on('connect')
socket.on('connect', function() {
const client = h2.createClientSession(socket);

pathname = `/${Math.random()}`;

const headers = {
':method': 'GET',
':scheme': 'http',
':authority': `localhost:${this.address().port}`,
':path': '/'
':path': pathname

@mcollinamcollinaMar 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please create a new test for this?

@sebdeckerssebdeckersMar 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina I could add a test case for this fix to the test script in #47. So would need that to land in master branch first, then update this PR with the test case.

};

const req = client.request(headers);
Expand Down