Uh oh!
There was an error while loading. Please reload this page.
Make the text black - #366
Conversation
therebelrobot
commented
Jun 1, 2015
@decadent, most design changes are most likely not going to be merged because we decided to focus design updates into the new converged site. If any WG members think otherwise, lemme know. @nodejs/website this raises a good question though: what concessions should be made for accessibility in the new site? IMO, there is a point where style takes precedent over readability, take for example the gray text vs the black text here on Github. Maybe a good option would be to lighten the background? Or provide an easy to find accessible version of the site somewhere? |
therebelrobot
commented
Jun 1, 2015
Also, the gray text gives emphasis on the black links, which if all text was black, the focus points would be lost save for the underlining. From a design aspect, that would be a bad move. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
robertkowalski
commented
Jun 1, 2015
i don't really have strong opinions on dark/light but maybe it would be awesome to provide a website with a dynamic dark/light option (button) or even better with a lot more helpers for accessibility (aria and friends for screenreaders etc) |
robertkowalski
commented
Jun 1, 2015
(as an answer to @therebelrobot's first question) |
decadent
commented
Jun 2, 2015
Let me add an explanation since it seems to be needed. Besides being a readability parameter, contrast is also a design tool. You use it to emphasize or deemphasize things. Body text is not an obscure detail of your site so don't deemphasize it. You don't need a separate 'accessible' version, at least for the black text, because vast majority of users, including me (for example), would benefit from high text-to-background contrast in the 'normal' design version. I can't say for the elderly (yet) but users with moderate eyesight loss don't have problems with grey menus or footers or a couple of paragraphs of grey text, they have problems with screenfuls of body text set in low contrast colors. Github doesn't use Do I need to quote sources for what seemed like common knowledge by now?
That problem has been solved at some time around the days of HTML 1.0. Just make links other color than black. Preferably blue for easy recognition but it's not mandatory. Also I wouldn't think that you want to put a special emphasis on links in a page full of text. If links are your main feature then just make a list of links. Normally you want to make links easily discernible but not make them jump out from the page, which is what unusually high link-to-text contrast does. It's especially a shame that a site for web design folks sets such an example. |
bnb
commented
Jun 2, 2015
@decadent We understand design principles just as much as you do - you don't need to take such a negative postion. Insulting the WG members and developers isn't a good way to make a change happen. As @therebelrobot said in his first comment, design changes are most likely not going to be accepted into this repo anymore, as it is soon to be deprecated. |
bnb
commented
Jun 2, 2015
@robertkowalski Is the new site going to be using jQuery or not? I can probably write up a script that can change night/day settings either way - I'm a novice programmer, so I'd like to give it a shot and hopefully learn something. |
Fishrock123
commented
Jun 2, 2015
I wouldn't be opposed to it if it helps people, does someone want to get a screenshot of what it might look like? Otherwise I'll try to at some point. |
Fishrock123
commented
Jun 2, 2015
I would prefer to not use jQuery, does nodejs.org use it? All we need to to attach a click and store a boolean, and have it modify the |
bnb
commented
Jun 2, 2015
@Fishrock123 Just looked at the main page of nodejs.org, and there's no jQuery includes. They do, however, use Typekit - we could probably leverage that to our advantage. |
fhemberger
commented
Jun 3, 2015
We don't really need a light/dark theme switch. People with visual impairment usually have their own custom user stylesheet adapted to their needs or use the operating system's high contrast/text sizing or screen magnifier functions. We just have to make sure, that the overall website provides enough contrast. You can use tools like Colour Contrast Checker or WAVE for general a11y checks. Here is the report for the current io.js website: http://wave.webaim.org/report#/https%3A%2F%2Fiojs.org%2Fen%2Findex.html (a text color of |
bnb
commented
Jun 3, 2015
@fhemberger Thanks for the test link. With the light/dark switcher, I don't think it was to help visually impaired; rather, it was just a nice, simple to implement feature for the site. |
Fishrock123
commented
Jun 3, 2015
I would rather not have to worry about 2 styles. I think we should at least darken the regular text. The op reported it, and I'm not an expert on it. |
therebelrobot
commented
Jun 4, 2015
As far as the new site design is concerned, was the consensus that it was gonna be designed by a design agency, managed through the marketing group? If so, this discussion for that would be a moot point, as we wouldn't even be handling the color choices in the end, just build. As for the io.js site, I still reiterate my original position: design changes should be saved for and merged into the new one, and more or less just maintain this repo as-is so far as design is concerned. |
therebelrobot
commented
Jun 4, 2015
But yes, I agree with @Fishrock123 that 2 stylesheets would be too encumbering, and with @fhemberger that if accessibility is needed, we should build it so it can be accessed by normal accessibility tools, and let them do their jobs, rather than rebuilding it all in ourselves. |
Addresses accessibility issues discussed in #366.
fhemberger
commented
Jun 30, 2015
I optimized the legibility in d663160, I think we can close this for now. General a11y related discussions are probably better placed in https://github.com/nodejs/new.nodejs.org. |
bnb
commented
Jun 30, 2015
+1. Closing. |
Just do it.
I'm your textbook poor eyesight user. Don't make my eyes suffer.