Uh oh!
There was an error while loading. Please reload this page.
build: refactor os-specific scripts into different files - #175
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
commented
Mar 16, 2018
MemberAuthor
@richardlau Updated, PTAL, thanks! |
joyeecheung
commented
Mar 16, 2018
MemberAuthor
I also tested Fedora 27 with lldb 5.0. This is what I used to do the testing: https://gist.github.com/joyeecheung/f458f9a668e0e9546d48d899298e7331 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This patch refactors all the OS-specific configuration scripts into separate files: - `scripts/linux.js` for Linux - `scripts/darwin.js` for macOS - `scripts/freebsd.js` for FreeBSD And put lldb-specific code into `scripts/lldb.js`. The `scripts/configure.js` now runs a `main()` function that calls other functions so the configuration code is now more readable. Also adds comments in the configuration scripts and more console outputs during the installation to help users find issues about their installation. Tested with the following combinations (with `npm install`): - macOS 10.12 + Xcode 9.2 - macOS 10.12 + lldb 5.0 (installed with `brew install --with-lldb --with-toolchain llvm`) - Ubuntu 16.04 + lldb 4.0 (`apt-get install lldb-4.0 liblldb-4.0-dev`) - FreeBSD 11 + lldb40 (comes with lldb40, need to `pkg install llvm40` to install the headers) - FreeBSD 11 + lldb50 (`pkg install llvm50` and relink `/usr/bin/lldb` to `/usr/local/bin/lldb50`) - CentOS 7 + lldb 4.0 from llvm-toolset-7 in the SCL - Fedora 27 + lldb 5.0 has been tested.
joyeecheungforce-pushed
the
refactor-os-build
branch
from
March 18, 2018 11:47
a82298d to
416cac9Comparejoyeecheung
commented
Mar 18, 2018
MemberAuthor
Rebased and squashed to see if we have any luck to get a green CI with #176 landed |
joyeecheung
commented
Mar 18, 2018
MemberAuthor
CI is green, merging... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch refactors all the OS-specific configuration scripts
into separate files:
scripts/linux.jsfor Linuxscripts/darwin.jsfor macOSscripts/freebsd.jsfor FreeBSDAnd put lldb-specific code into
scripts/lldb.js.The
scripts/configure.jsnow runs amain()functionthat calls other functions so the configuration code
is now more readable.
Also adds comments in the configuration scripts
and more console outputs during the installation
to help users find issues about their installation.
Tested with the following combinations (with
npm install):brew install --with-lldb --with-toolchain llvm)apt-get install lldb-4.0 liblldb-4.0-dev)pkg install llvm40to install the headers)pkg install llvm50and relink/usr/bin/lldbto/usr/local/bin/lldb50)