Uh oh!
There was an error while loading. Please reload this page.
test: refactor inspect-test - #176
Merged
Merged
Conversation
- Make the test messages more informative. - Refactor the test flow so that we could skip flaky properties (currently the potentially neutered typed array) and that one missing property does not stop later tests.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
CI now skips the neutered typed array https://travis-ci.org/nodejs/llnode/jobs/354456004 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
commented
Mar 18, 2018
MemberAuthor
Updated the optional regexp per suggestion by @bnoordhuis . |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(currently the potentially neutered typed array)
and that one missing property does not stop later tests.
Refs: #150
We should now be able to skip #150 , it remains a question whether this should be fixed (or is it fixable?)
TAP output of inspect-test.js before this patch
TAP output of inspect-test.js after this patch (removed a few redundant `t.error(err) in callbacks`)