Skip to content

src: improve messages on CheckCast - #1507

Merged
mhdawson merged 2 commits into
nodejs:mainfrom
legendecas:check_cast_msg
Jun 14, 2024
Merged

src: improve messages on CheckCast#1507
mhdawson merged 2 commits into
nodejs:mainfrom
legendecas:check_cast_msg

Conversation

@legendecas

@legendecaslegendecas commented May 23, 2024

Copy link
Copy Markdown
Member

Print actual value type if the check failed.

BEGIN_COMMIT_OVERRIDE
feat: improve messages on CheckCast (#1507)
END_COMMIT_OVERRIDE

@codecov-commenter

codecov-commenter commented May 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.51%. Comparing base (23bb42b) to head (4cfeb29).
Report is 17 commits behind head on main.

FilesPatch %Lines
napi-inl.h0.00%5 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1507 +/- ##
==========================================
- Coverage 64.71% 64.51% -0.20% 
==========================================
Files 3 3 Lines 1981 1987 +6 Branches 687 687 ==========================================
Hits 1282 1282 - Misses 138 144 +6 
Partials 561 561 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment threadnapi.h Outdated
Comment threadnapi.h Outdated
Print actual value type if the check failed.
Comment threadnapi-inl.h
Comment threadnapi.h Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas@codecov-commenter@vmoroz@gabrielschulhof@mhdawson