Uh oh!
There was an error while loading. Please reload this page.
src: change guards to NAPI_VERSION > 5 - #697
Closed
gabrielschulhof wants to merge 1 commit into
Closed
Conversation
gabrielschulhofforce-pushed
the
remove-NODE_MAJOR_VERSION-guards
branch
2 times, most recently
from
April 7, 2020 22:05
3acf151 to
4f19ef7Comparegabrielschulhof
requested review from
KevinEady, NickNaso, devsnek, legendecas and mhdawsonApril 7, 2020 22:05
gabrielschulhofforce-pushed
the
remove-NODE_MAJOR_VERSION-guards
branch
from
April 7, 2020 22:32
4f19ef7 to
0d23cd9CompareNickNaso
requested changes
Apr 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gabrielschulhofforce-pushed
the
remove-NODE_MAJOR_VERSION-guards
branch
from
April 10, 2020 05:08
0d23cd9 to
5e0bcd7Comparegabrielschulhof
commented
Apr 10, 2020
ContributorAuthor
@NickNaso I removed the extra comments. |
gabrielschulhof
commented
Apr 10, 2020
ContributorAuthor
@NickNaso looks like your subsequent approval did not clear your previous request for changes. Can you please dismiss? |
NickNaso
dismissed
their stale reviewApril 10, 2020 16:12
My approval did not clear changes that I requested.
gabrielschulhof
commented
Apr 11, 2020
ContributorAuthor
@NickNaso looks like dismissing your change request also dismissed your approval. Could you please re-approve? |
ContributorAuthor
8 tasks
gabrielschulhofforce-pushed
the
remove-NODE_MAJOR_VERSION-guards
branch
from
April 13, 2020 15:11
5e0bcd7 to
b737089Comparegabrielschulhof
commented
Apr 13, 2020
ContributorAuthor
On Windows it looks like one cannot distinguish between thread IDs using http://docs.libuv.org/en/v1.x/threading.html#c.uv_thread_equal. |
gabrielschulhof
commented
Apr 13, 2020
ContributorAuthor
nodejs/node#32823 should fix this problem. |
2 tasks
gabrielschulhof pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
4 tasks
gabrielschulhof pushed a commit
to nodejs/node
that referenced
this pull request
Apr 16, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32880 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
MylesBorins pushed a commit
to nodejs/node
that referenced
this pull request
Apr 17, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32880 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
gabrielschulhof pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 20, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs#32880 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
NickNaso
commented
Apr 23, 2020
Member
@gabrielschulhof Could I merge this PR? |
gabrielschulhof
commented
Apr 23, 2020
ContributorAuthor
@NickNaso I don't believe the tests will pass on 14, 13, 12, and 10 without nodejs/node#32948. |
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly, and end our reliance on guarding by `NODE_MAJOR_VERSION`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
gabrielschulhofforce-pushed
the
remove-NODE_MAJOR_VERSION-guards
branch
from
April 24, 2020 22:27
b737089 to
9ace39eCompareContributorAuthor
gabrielschulhof pushed a commit
that referenced
this pull request
Apr 24, 2020
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly, and end our reliance on guarding by `NODE_MAJOR_VERSION`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #697 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof
commented
Apr 24, 2020
ContributorAuthor
Landed in 82a9650. |
targos pushed a commit
to nodejs/node
that referenced
this pull request
Apr 28, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32880 Backport-PR-URL: #32948 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
kevindavies8 added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly, and end our reliance on guarding by `NODE_MAJOR_VERSION`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs/node-addon-api#697 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly, and end our reliance on guarding by `NODE_MAJOR_VERSION`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs/node-addon-api#697 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly, and end our reliance on guarding by `NODE_MAJOR_VERSION`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs/node-addon-api#697 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Since we have made the decision that we shall include `BigInt` into N-API 6, we can change the guards for the `BigInt` and `BigInt`-based typed array wrappers accordingly, and end our reliance on guarding by `NODE_MAJOR_VERSION`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs/node-addon-api#697 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have made the decision that we shall include
BigIntintoN-API 6, we can change the guards for the
BigIntandBigInt-basedtyped array wrappers accordingly, and end our reliance on guarding by
NODE_MAJOR_VERSION.Signed-off-by: @gabrielschulhof
Supersedes #694.