Uh oh!
There was an error while loading. Please reload this page.
[v13.x] Backport thread-safe function deadlock detection fix - #32948
Closed
gabrielschulhof wants to merge 2 commits into
Closed
[v13.x] Backport thread-safe function deadlock detection fix#32948gabrielschulhof wants to merge 2 commits into
gabrielschulhof wants to merge 2 commits into
Conversation
added 2 commits
April 20, 2020 08:36
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs#32880 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. Fixes: nodejs#32615 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs#32860 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
gabrielschulhof
commented
Apr 20, 2020
ContributorAuthor
The backport would normally apply cleanly, but the resulting doc entry would have a REPLACEME tag for the `napi_call_threadsafe_function() entry indicating the change that brings deadlock detection, whereas the deadlock detection was not reverted out of the v13.x branch like it was in master, so that tag has to be manually updated to stay as "v13.13.0". |
gabrielschulhof
requested review from
addaleax, cjihrig, legendecas and mhdawsonApril 20, 2020 16:13
nodejs-github-bot
commented
Apr 21, 2020
Collaborator
nodejs-github-bot
commented
Apr 21, 2020
Collaborator
gabrielschulhof
commented
Apr 21, 2020
ContributorAuthor
This PR is also not semver-minor for that reason. |
legendecas
approved these changes
Apr 24, 2020
mhdawson
commented
Apr 24, 2020
Member
I'm not sure at this point if there will be a another 13.x release. |
addaleax
commented
Apr 24, 2020
Member
Right, any further v13.x Release would be a maintenance release, where I believe this wouldn’t fit in. |
Member
There will be one last regular v13.x release next week. Edit: ref: nodejs/Release#487 |
gabrielschulhof
commented
Apr 26, 2020
ContributorAuthor
@targos it would be good if this made it into the final v13.x release because, as things stand, v13.x is buggy on Windows. |
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32880 Backport-PR-URL: #32948 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. Fixes: #32615 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32860 Backport-PR-URL: #32948 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos
commented
Apr 28, 2020
Member
Landed in ea85768...fd4320c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes