ncu-ci: command that shows results of jenkins by joyeecheung · Pull Request #161 · nodejs/node-core-utils

joyeecheung · 2018-01-30T08:48:27Z

Example:

▶ show-ci pr 12798
{ result: 'FAILURE',
failures:
[ { url: 'https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/12151/',
reason: 'ERROR: Error cloning remote repo \'origin\'' },
{ url: 'https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_fips20_x64/1774/',
reason: 'not ok 462 parallel/test-fs-error-messages' } ] }

joyeecheung · 2018-01-30T08:54:58Z

Refs: #158

Some other commands to implement

show-ci benchmarkhttps://gist.github.com/joyeecheung/b55c88ee465d552d7ed1dc34e67305ea
show-ci stress: display if the tests run by node-stress-single-test are flaky and how many runs failed

codecov · 2018-02-01T15:01:58Z

Codecov Report

Merging #161 into master will decrease coverage by 8.74%.
The diff coverage is 61.28%.

@@ Coverage Diff @@## master #161 +/- ##
==========================================
- Coverage 88.52% 79.77% -8.75% 
==========================================
Files 19 20 +1 Lines 723 1078 +355 ==========================================
+ Hits 640 860 +220 - Misses 83 218 +135

Impacted Files	Coverage Δ
lib/cli.js	`52.11% <ø> (ø)`	⬆️
lib/cache.js	`100% <100%> (ø)`
lib/pr_data.js	`96.15% <100%> (+0.32%)`	⬆️
lib/pr_checker.js	`98.39% <100%> (-0.01%)`	⬇️
lib/file.js	`70.83% <20%> (+7.67%)`	⬆️
lib/ci.js	`59.29% <54.54%> (-33.74%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dafebf...766fc91. Read the comment docs.

joyeecheung · 2018-02-02T10:59:19Z

A bit more progress...

joyeecheung · 2018-03-03T10:44:36Z

On Windows ERROR: coming from the preparation tasks can be ignored. Should not hide the real errors appeared later on.
https://gist.github.com/joyeecheung/5a1a92cc7d8dc65502bb564ad5cc9e7e

Refs: nodejs/node#19041

joyeecheung · 2018-04-07T02:04:12Z

Added tests to cache and the jenkins utilities...should be able to land after documentations are added

- Put the PR URL parsing logic in links.js and reuse it - Differentiate PR and commit jobs in preparation for #161 - Updates a few CI link patterns

mmarchini

Awesome work!

mmarchini · 2018-05-23T19:29:09Z

@joyeecheung I can help with documentation if you want.

joyeecheung · 2018-05-31T14:15:23Z

Docs added, new demo: https://asciinema.org/a/184727

This should be ready to land cc @nodejs/automation

joyeecheung · 2018-05-31T16:01:22Z

This has been approved by @mmarchini but I still prefer to have some reviews @nodejs/automation before merging. It would be nice to be able to land this before tomorrow's collaboration summit so I can make a release and people can start trying this out - currently I believe the pattern matching of the CI results are not smart enough and we will bump into edge cases from time to time. The more people trying this the better coverage we can have.

priyank-p

I left couple of comments, overall LGTM, Nice work!

I still quite did not get what the purpose of the cache module, just by reading trough it?

priyank-p · 2018-05-31T20:41:22Z

+class Cache {
+ constructor(dir) {
+ this.dir = dir || path.join(__dirname, '..', '.ncu', 'cache');
+ this.originals = {};


I'd would have prefer this to be a Map instead of plain object, for readability.

priyank-p · 2018-05-31T20:45:37Z

+ }
+ });
+
+ it('should cache sync restuls', () => {


Typo, results.

priyank-p · 2018-05-31T20:45:56Z

+ assert.strictEqual(cached, expected);
+ });
+
+ it('should cache async restuls', async() => {


priyank-p · 2018-05-31T20:51:41Z

 });
 });
+
+describe('Jeknins', () => {


typo Jenkins.

priyank-p · 2018-05-31T20:58:13Z

- PRBuild, BenchmarkRun, CommitBuild, jobCache, parseJobFromURL, constants
+ PRBuild, BenchmarkRun, CommitBuild, parseJobFromURL,
+ constants, JobParser
+ // , jobCache


I think this was left by mistake.

Oops, i was looking trough each commit.

priyank-p · 2018-05-31T21:00:38Z

 // This is used for testing
 // Default cache dir is ${ncu-source-dir}/.ncu/cache
-jobCache.enable();
+// jobCache.enable();


Do we need get rid this block now that this is not required for tests?

joyeecheung · 2018-06-01T00:25:53Z

@priyankp10 Thanks for the review! The cache is there for development: e.g. when you are working on the pattern-matching rules you would not want to wait for the tool to grab all the data from Jenkins each time you run it.

- Put the PR URL parsing logic in links.js and reuse it - Differentiate PR and commit jobs in preparation for nodejs/node-core-utils#161 - Updates a few CI link patterns

joyeecheung changed the title ~~WIP: command that shows results of node-test-pull-request~~WIP: command that shows results of jenkinsJan 30, 2018

joyeecheung mentioned this pull request Feb 9, 2018
Fixathon / bug hunt nodejs/node#18660
Closed

joyeecheung force-pushed the show-ci branch 2 times, most recently from 1d14de5 to 18fcbe7Compare February 28, 2018 00:13

joyeecheung force-pushed the show-ci branch from 18fcbe7 to 4a5c59eCompare March 9, 2018 04:46

joyeecheung force-pushed the show-ci branch from 4a5c59e to 87e9c6eCompare March 20, 2018 12:53

joyeecheung mentioned this pull request Mar 26, 2018
avoid CI typos nodejs/automation#26
Closed

joyeecheung force-pushed the show-ci branch 3 times, most recently from 9d8b2e1 to e963f1fCompare April 7, 2018 02:02

joyeecheung force-pushed the show-ci branch 2 times, most recently from 7996277 to 4451d21Compare April 22, 2018 10:35

joyeecheung mentioned this pull request Apr 22, 2018
lib: clean up PR and CI url parsing logic #242
Merged

joyeecheung force-pushed the show-ci branch from 4451d21 to 976bef4Compare April 22, 2018 13:12

joyeecheung added a commit that referenced this pull request Apr 22, 2018
lib: clean up PR and CI url parsing logic (#242)
d6ce6dc
- Put the PR URL parsing logic in links.js and reuse it - Differentiate PR and commit jobs in preparation for #161 - Updates a few CI link patterns

mmarchini approved these changes May 23, 2018
View reviewed changes

mmarchini mentioned this pull request May 30, 2018
Project Velocity and PR reviews openjs-foundation/summit#64
Closed

joyeecheung force-pushed the show-ci branch 6 times, most recently from bfc7e0f to 72782ddCompare May 31, 2018 14:06

joyeecheung changed the title ~~WIP: command that shows results of jenkins~~ncu-ci: command that shows results of jenkinsMay 31, 2018

joyeecheung force-pushed the show-ci branch from 035eb9f to 7e20c79Compare May 31, 2018 14:17

priyank-p approved these changes May 31, 2018
View reviewed changes

joyeecheung added 5 commits June 1, 2018 02:26

lib: add cache utility
3e614ef

ncu-ci: initial implementation
9c45921

ncu-ci: replace --markdown with --copy
ee5b43b

ncu-ci: support parsing CI links from PR thread
353c812

ncu-ci: add docs
766fc91

joyeecheung force-pushed the show-ci branch from ddaace7 to 766fc91Compare June 1, 2018 00:26

riyadhalnur approved these changes Jun 1, 2018
View reviewed changes

joyeecheung merged commit bb0d70f into nodejs:masterJun 1, 2018

Uh oh!

Conversation

joyeecheung commented Jan 30, 2018

Uh oh!

joyeecheung commented Jan 30, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Feb 1, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joyeecheung commented Feb 2, 2018

Uh oh!

joyeecheung commented Mar 3, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Apr 7, 2018

Uh oh!

mmarchini left a comment

Choose a reason for hiding this comment

Uh oh!

mmarchini commented May 23, 2018

Uh oh!

joyeecheung commented May 31, 2018

Uh oh!

joyeecheung commented May 31, 2018

Uh oh!

priyank-p left a comment

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

priyank-pMay 31, 2018

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jun 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joyeecheung commented Jan 30, 2018•
edited
Loading

codecovBot commented Feb 1, 2018•
edited
Loading

joyeecheung commented Mar 3, 2018•
edited
Loading