Uh oh!
There was an error while loading. Please reload this page.
lib: clean up PR and CI url parsing logic - #242
Merged
Conversation
joyeecheung
commented
Apr 22, 2018
Member
- Put the PR URL parsing logic in links.js and reuse it
- Differentiate PR and commit jobs in preparation for ncu-ci: command that shows results of jenkins #161
- Updates a few CI link patterns
Codecov Report
@@ Coverage Diff @@## master #242 +/- ##
==========================================
- Coverage 88.55% 88.52% -0.04%
==========================================
Files 19 19 Lines 708 723 +15 ==========================================
+ Hits 627 640 +13 - Misses 81 83 +2
Continue to review full report at Codecov.
|
joyeecheung
commented
Apr 22, 2018
MemberAuthor
cc @nodejs/automation |
priyank-p
approved these changes
Apr 22, 2018
priyank-p
left a comment
Contributor
There was a problem hiding this comment.
The cleanup looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.