Skip to content

test: test collaborator names with parentheses - #348

Merged
priyank-p merged 1 commit into
nodejs:masterfrom
joyeecheung:extension
May 29, 2019
Merged

test: test collaborator names with parentheses#348
priyank-p merged 1 commit into
nodejs:masterfrom
joyeecheung:extension

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented May 29, 2019

Copy link
Copy Markdown
Member

张三 is roughly the Chinese version of John Doe (modulo it is not used for corpses)

@codecov

codecovBot commented May 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #348 +/- ##
======================================
Coverage 75.8% 75.8% ======================================
Files 21 21 Lines 1368 1368 ======================================
Hits 1037 1037 Misses 331 331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3229743...3c22581. Read the comment docs.

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(modulo it is not used for corpses)

Well, TIL … 😄

@ChALkeR

Copy link
Copy Markdown
Member

Is there an ncu test with rtl language text somewhere?

@priyank-p
priyank-p merged commit 412e68a into nodejs:masterMay 29, 2019
@priyank-p

Copy link
Copy Markdown
Contributor

Is there an ncu test with rtl language text somewhere?

As far as I can remember, there are no tests for rtl text.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joyeecheung@ChALkeR@priyank-p@addaleax