Uh oh!
There was an error while loading. Please reload this page.
meta: correct personal info - #27940
Closed
refack wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
May 28, 2019
ChALkeR
approved these changes
May 28, 2019
joyeecheung
commented
May 29, 2019
Member
Added a test for this extension in ncu to make sure it does not regeress nodejs/node-core-utils#348 |
BridgeAR
approved these changes
May 29, 2019
nodejs-github-bot
commented
May 29, 2019
Collaborator
trivikr
approved these changes
May 29, 2019
Trott
approved these changes
May 30, 2019
benjamingr
approved these changes
May 30, 2019
Trott
commented
Jun 2, 2019
Member
Landed in 41a35e0 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2019
PR-URL: nodejs#27940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 3, 2019
PR-URL: #27940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes