Investigate flaky test - test-gc-http-client-onerror.js

[mhdawson]

Test

test-gc-http-client-onerror.js

Platform

freebsd

Console output

/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/parallel/test-gc-http-client-onerror.js:50
 throw err;
 ^

Error: connect ECONNRESET 127.0.0.1:10490 - Local (127.0.0.1:20028)
 at internalConnect (node:net:931:16)
 at defaultTriggerAsyncIdScope (node:internal/async_hooks:465:18)
 at GetAddrInfoReqWrap.emitLookup [as callback] (node:net:1075:9)
 at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:74:8) {
 errno: -54,
 code: 'ECONNRESET',
 syscall: 'connect',
 address: '127.0.0.1',
 port: 10490
}

Node.js v18.0.0-pre

Build links

• https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd12-x64/42284/testReport/junit/(root)/test/parallel_test_gc_http_client_onerror/

Additional information

No response

[lpinca]

I can reproduce this by running

./tools/test.py --repeat=1000 test/parallel/test-gc-http-client-onerror

on macOS (16 parallel tasks) but I cannot reproduce it on Windows and Linux (8 parallel tasks).

I can make the test pass reliably on macOS by reducing parallelism, the duration of the TIME_WAIT state, and increasing the number ephemeral ports.

sudo sysctl -w net.inet.ip.portrange.first=32768
sudo sysctl net.inet.tcp.msl=1000
./tools/test.py -j5 --repeat=1000 test/parallel/test-gc-http-client-onerror

I wonder if it makes sense to move it to sequential like it was done for its companion test-gc-http-client.js in 7d03ff1.