Skip to content

test: move test-gc-http-client-onerror to sequential - #41619

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:move/test-gc-http-client-onerror-to-sequential
Jan 22, 2022
Merged

test: move test-gc-http-client-onerror to sequential#41619
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:move/test-gc-http-client-onerror-to-sequential

Conversation

@lpinca

@lpincalpinca commented Jan 20, 2022

Copy link
Copy Markdown
Member

Fixes: #41399

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 20, 2022
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Jan 21, 2022
Open
19 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42066/

@github-actionsgithub-actionsBot mentioned this pull request Jan 22, 2022
Open
17 tasks
@lpincalpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 22, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2022
@nodejs-github-bot
nodejs-github-bot merged commit d01c645 into nodejs:masterJan 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2022

Copy link
Copy Markdown
Collaborator

Landed in d01c645

@lpinca
lpinca deleted the move/test-gc-http-client-onerror-to-sequential branch January 22, 2022 19:33
This was referenced Jan 23, 2022
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@lpinca@BethGriggs
test: move test-gc-http-client-onerror to sequential
ea6c202
Fixes: #41399
PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@lpinca@danielleadams
test: move test-gc-http-client-onerror to sequential
ac4288c
Fixes: #41399
PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@lpinca@danielleadams
test: move test-gc-http-client-onerror to sequential
4c5e0ba
Fixes: #41399
PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@lpinca@danielleadams
test: move test-gc-http-client-onerror to sequential
fbaf1dc
Fixes: #41399
PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@lpinca@danielleadams
test: move test-gc-http-client-onerror to sequential
950648d
Fixes: #41399
PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@santigimenosantigimenosantigimeno approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test - test-gc-http-client-onerror.js

5 participants

@lpinca@nodejs-github-bot@Trott@santigimeno@cjihrig