Uh oh!
There was an error while loading. Please reload this page.
doc: fix awkward sentence for fs.utimes() - #10005
Closed
dguo wants to merge 1 commit into
Closed
Conversation
mscdex
commented
Dec 1, 2016
Contributor
First line of the commit message should be <= 50 characters. |
dguo
commented
Dec 1, 2016
ContributorAuthor
Thanks. I fixed the commit message. |
cjihrig
commented
Dec 5, 2016
Contributor
I'm not sure what makes this easier to understand. |
dguo
commented
Dec 5, 2016
ContributorAuthor
I realize it's very minor, but it sounds quite awkward (to me) when I read it aloud because it uses a passive voice. Please feel free to close this though if you think it's fine the way it is. |
jasnell
commented
Dec 5, 2016
Member
Yeah, I really appreciate the contribution but I think I prefer the original |
dguo
commented
Dec 5, 2016
ContributorAuthor
Fair enough. Thank you all for taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
I made some minor edits to this documentation with #8651, and I just noticed that one of the sentences sounds awkward, so here's a fix.