Skip to content

doc: fix awkward sentence for fs.utimes() - #10005

Closed
dguo wants to merge 1 commit into
nodejs:masterfrom
dguo:doc-fs-utimes-nit
Closed

doc: fix awkward sentence for fs.utimes()#10005
dguo wants to merge 1 commit into
nodejs:masterfrom
dguo:doc-fs-utimes-nit

Conversation

@dguo

@dguodguo commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc

Description of change

I made some minor edits to this documentation with #8651, and I just noticed that one of the sentences sounds awkward, so here's a fix.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Dec 1, 2016
@mscdex

Copy link
Copy Markdown
Contributor

First line of the commit message should be <= 50 characters.

@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@dguodguo changed the title doc: change awkward sounding sentence for fs.utimes()doc: fix awkward sentence for fs.utimes()Dec 1, 2016
@dguo

dguo commented Dec 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Thanks. I fixed the commit message.

@cjihrig

Copy link
Copy Markdown
Contributor

I'm not sure what makes this easier to understand.

@dguo

dguo commented Dec 5, 2016

Copy link
Copy Markdown
ContributorAuthor

I realize it's very minor, but it sounds quite awkward (to me) when I read it aloud because it uses a passive voice. Please feel free to close this though if you think it's fine the way it is.

@jasnell

Copy link
Copy Markdown
Member

Yeah, I really appreciate the contribution but I think I prefer the original

@dguo

dguo commented Dec 5, 2016

Copy link
Copy Markdown
ContributorAuthor

Fair enough. Thank you all for taking a look.

@dguodguo closed this Dec 5, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@dguo@mscdex@cjihrig@jasnell@imyller@nodejs-github-bot