Uh oh!
There was an error while loading. Please reload this page.
doc: clarify fs.utimes() arguments - #8651
Closed
dguo wants to merge 1 commit into
Closed
Conversation
not-an-aardvark
approved these changes
Sep 19, 2016
addaleax
approved these changes
Sep 19, 2016
Member
There was a problem hiding this comment.
nit: I realize it’s copied, but numerable sounds a bit weird to me… maybe just “numeric”?
ContributorAuthor
There was a problem hiding this comment.
Good point. I updated the commit with numeric.
Make it clear that atime and mtime should be in seconds.
dguoforce-pushed
the
8638-fs-utimes-docs
branch
from
September 19, 2016 12:55
2dc1298 to
bd2f332Comparejasnell pushed a commit
that referenced
this pull request
Sep 20, 2016
Make it clear that atime and mtime should be in seconds. PR-URL: #8651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
jasnell
commented
Sep 20, 2016
Member
Landed in 99ab686. Thank you! |
Fishrock123 pushed a commit
that referenced
this pull request
Oct 11, 2016
Make it clear that atime and mtime should be in seconds. PR-URL: #8651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Make it clear that the
atimeandmtimearguments tofs.utimes()should be in seconds.Fixes#8638