Uh oh!
There was an error while loading. Please reload this page.
test: Modernize test-tls-peer-certificate.js - #10014
Closed
ipotuzhnov wants to merge 1 commit into
Closed
Conversation
mscdex
commented
Dec 1, 2016
Contributor
nit: the period at the end of the first line of the commit message is unnecessary |
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)`
ipotuzhnovforce-pushed
the
modernize-tls-peer-certificate-test
branch
from
December 1, 2016 17:54
ea32dfe to
24f16d3Comparecjihrig
approved these changes
Dec 5, 2016
mhdawson
commented
Dec 5, 2016
Member
jasnell
approved these changes
Dec 5, 2016
mhdawson
commented
Dec 5, 2016
Member
Freebsd failures related to #10130, arm failure machine type issue as opposed to test failure so CI run looks ok in terms of this change. Going to land |
mhdawson
commented
Dec 5, 2016
Member
Landed as 0a265df |
mhdawson pushed a commit
that referenced
this pull request
Dec 5, 2016
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: #10014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
Fishrock123 pushed a commit
that referenced
this pull request
Dec 6, 2016
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: #10014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: nodejs#10014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
jmdarling pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: nodejs#10014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: #10014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This was referenced Nov 29, 2023
This was referenced Dec 10, 2023
This was referenced Dec 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Modernize
test/parallel/test-tls-peer-certificate.jsaccording to thefollowing rules:
var-->const/letassert.equal-->assert.strictEqualassert.ok(a === b)-->assert.strictEqual(a, b)