Skip to content

V6.9.3 proposal - #10394

Merged
MylesBorins merged 313 commits into
v6.xfrom
v6.9.3-proposal
Jan 3, 2017
Merged

V6.9.3 proposal#10394
MylesBorins merged 313 commits into
v6.xfrom
v6.9.3-proposal

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

2017-01-03, Version 6.9.3 'Boron' (LTS), @MylesBorins

This LTS release comes with 312 commits. This includes 229 that are test related,
62 that are docs related, 17 which are build / tools related, and 4 commits which
are updates to dependencies.

Notable Changes

  • build: shared library support is now working for AIX builds (Stewart Addison) #9675
  • deps:
    • npm: upgrade npm to 3.10.10 (Rebecca Turner) #9847
    • V8: Destructuring of arrow function arguments via computed property no longer throws (Michaël Zasso) #10386
  • inspector: /json/version returns object, not an object wrapped in an array (Ben Noordhuis) #9762
  • module: using --debug-brk and --eval together now works as expected (Kelvin Jin) #8876
  • process: improve performance of nextTick up to 20% (Evan Lucas) #8932
  • repl:
    • the division operator will no longer be accidentally parsed as regex (Teddy Katz) #10103
    • improved support for generator functions (Teddy Katz) #9852
  • timers: Re canceling a cancelled timers will no longer throw (Jeremiah Senkpiel) #9685

Commits

Johnny Readingand others added 30 commits December 8, 2016 03:02
Use const instead of var for assignments.
PR-URL: #9951
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Replaces the use of assert.equal() with assert.strictEqual in test
code.
PR-URL: #9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Change var to const.
PR-URL: #10055
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #9874
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`
PR-URL: #9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
this change is part of code and learn (NINA-2016)
PR-URL: #9877
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Replace assert.equal with assert.strictEqual
PR-URL: #9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test
PR-URL: #9886
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.
PR-URL: #9888
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Use const over var.
Assert error message with regex.
PR-URL: #9891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #9892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
assert.equal() -> assert.strictEqual()
PR-URL: #9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* convert assert.equal to assert.strictEqual
* convert var to const/let
PR-URL: #9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Changed all references from assert.Equal() to assert.strictEqual().
PR-URL: #10077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #9897
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual
PR-URL: #10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws
PR-URL: #9906
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 * assert.equal() -> assert.strictEqual()
PR-URL: #10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).
PR-URL: #10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Replaces var with const and adds common.mustCall().
PR-URL: #9967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Replaced var with const and let.
- Replaced assert.equal() with assert.strictEqual().
- Added error message checking for assert.throws().
PR-URL: #9971
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #9964
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refactored `test-tls-server-verify.js` to replace uses of `var` with
`const` and `let`. Also replaced uses of `assert.equal` with
`assert.strictEqual`.
PR-URL: #10076
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: #10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Use asssert.strictEqual to disallow coersion.
PR-URL: #10071
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Update var to let/const and replace arbitrary timeout.
PR-URL: #10064
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
use common.fail instead of assert(false)
change var to let or const as appropriate
PR-URL: #9900
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual
PR-URL: #9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
furnoxand others added 10 commits December 26, 2016 19:27
- Updated assert.equal to assert.strictEqual
- Updated 'var' to 'const'
- Using template literals
PR-URL: #10036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Creating a buffer from a number should throw an error with a message
that describes the issue.
PR-URL: #10038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
- `var` --> `const` as applicable
- `assert.equal` --> `assert.strictEqual`
- `assert(false, ..)` --> `common.fail()`
- `common.mustCall` for functions that need to be called exactly once
- modified an `assert(!signal, 'Worker exited by a signal');` call to
`assert.strictEqual(signal, null);` call as that made more sense
PR-URL: #10049
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to
assert.strictEqual. Wrapping functions called once with
common.mustCall
PR-URL: #10054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add a RegExp as a second argument to assert.throws().
PR-URL: #10058
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Use assert.strictEqual instead of assert.equal and assert.ok
PR-URL: #10420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Use assert.strictEqual() instead of assert.equal().
PR-URL: #10269
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Currently, two of the guides in the `/doc/guides` directory are actually
guides for working on the Nodei.js project. Of those, one is linked from
this page. This change adds a note to point people to the other.
PR-URL: #10070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Requiring a file from a directory that contains an invalid package.json
file should throw an error.
PR-URL: #10044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
It was added by mistake in
d283704
PR-URL: #10463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 27, 2016
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
Coming Soon
PR-URL: #10394
@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

one more run of spawn wrap to see if failure was infra related
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/502/

This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) #9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) #8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) #10103
- improved support for generator functions (Teddy Katz)
#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10394
@MylesBorins
MylesBorins merged commit 42149d7 into v6.xJan 3, 2017
MylesBorins added a commit that referenced this pull request Jan 3, 2017
MylesBorins added a commit that referenced this pull request Jan 3, 2017
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) #9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) #8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) #10103
- improved support for generator functions (Teddy Katz)
#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10394
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Jan 4, 2017
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
 This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
nodejs/node#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
nodejs/node#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) nodejs/node#9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) nodejs/node#8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
nodejs/node#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) nodejs/node#10103
- improved support for generator functions (Teddy Katz)
nodejs/node#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10394
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
 This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
nodejs/node#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
nodejs/node#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) nodejs/node#9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) nodejs/node#8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
nodejs/node#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) nodejs/node#10103
- improved support for generator functions (Teddy Katz)
nodejs/node#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10394
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@sam-github
sam-github deleted the v6.9.3-proposal branch March 6, 2017 16:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@MylesBorins@gibfahn@richardlau@mscdex@nodejs-github-bot@mitchellst@matt-wilson-cc@drifkin@rajatkumar@julianduque@pmasucci@Intregrisist@harishtejwani@WesTyler@jdharmon@bjdelro@digitalinfinity@cesarhq@radelmann@edsadr