Skip to content

test: test-crypto-domain.js - assert.equal -> assert.strictEqual - #10067

Closed
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:test-crypto-domain-patch
Closed

test: test-crypto-domain.js - assert.equal -> assert.strictEqual#10067
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:test-crypto-domain-patch

Conversation

@davidmarkclements

@davidmarkclementsdavidmarkclements commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, crypto

Description of change

changes assert.equal to assert.strictEqual to ensure specificity

edit: correct subsystem

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@julianduquejulianduque added crypto Issues and PRs related to the crypto subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
@davidmarkclementsdavidmarkclements changed the title test-crypto-domain.js assert.equal -> assert.strictEqualtest: test-crypto-domain.js - assert.equal -> assert.strictEqualDec 1, 2016
davidmarkclements
test: assert.equal -> assert.strictEqual
52fbbac
changes assert.equal to assert.strictEqual to ensure specificity
@addaleax

addaleax commented Dec 2, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/6323/

@addaleax

addaleax commented Dec 4, 2016

Copy link
Copy Markdown
Member

Landed in 26f0aec, thanks for the PR!

@addaleaxaddaleax closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 4, 2016
davidmarkclements@addaleax
test: assert.equal -> assert.strictEqual
26f0aec
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
davidmarkclements@addaleax
test: assert.equal -> assert.strictEqual
d87926a
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
davidmarkclements@addaleax
test: assert.equal -> assert.strictEqual
67b11a4
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: nodejs#10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
davidmarkclementsJonathan Darling
test: assert.equal -> assert.strictEqual
b355084
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: nodejs#10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
davidmarkclements@MylesBorins
test: assert.equal -> assert.strictEqual
d9cca39
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
davidmarkclements@MylesBorins
test: assert.equal -> assert.strictEqual
c37b48a
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
davidmarkclements@MylesBorins
test: assert.equal -> assert.strictEqual
2286863
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: #10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.cryptoIssues and PRs related to the crypto subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davidmarkclements@addaleax@cjihrig@MylesBorins@julianduque@nodejs-github-bot