Skip to content

test: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/let - #10074

Closed
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:test-https-truncate-patch
Closed

test: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/let#10074
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:test-https-truncate-patch

Conversation

@davidmarkclements

@davidmarkclementsdavidmarkclements commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, https

Description of change

changes assert.equal to assert.strictEqual to ensure specificity

changes var declarations to const/let where appropriate

edit: correct subsystem

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@santigimeno

santigimeno commented Dec 1, 2016

Copy link
Copy Markdown
Member

LGTM with the commit message following the contributing guideline.
CI: https://ci.nodejs.org/job/node-test-pull-request/5078/

cjihrig
cjihrig approved these changes Dec 1, 2016
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a fixed commit message.

@davidmarkclementsdavidmarkclements changed the title test-https-truncate.js: assert.equal -> assert.strictEqual, var -> const/lettest: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/letDec 1, 2016
davidmarkclements
test: equal -> strictEqual, var -> const/let
9ee01c5
changes assert.equal to assert.strictEqual to ensure specificity
changes var declarations to const/let where appropriate
@addaleaxaddaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 2, 2016
@mscdexmscdex added the https Issues or PRs related to the https subsystem. label Dec 3, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
davidmarkclements@Trott
test: refactor test-https-truncate
a6ddd57
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: nodejs#10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

Landed in a6ddd57. Thanks for the contribution! 🎉

@TrottTrott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
davidmarkclements@Fishrock123
test: refactor test-https-truncate
cf3c635
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: #10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
davidmarkclements@addaleax
test: refactor test-https-truncate
9b7d748
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: nodejs#10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
davidmarkclementsJonathan Darling
test: refactor test-https-truncate
9c52875
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: nodejs#10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
davidmarkclements@MylesBorins
test: refactor test-https-truncate
8257671
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: #10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
davidmarkclements@MylesBorins
test: refactor test-https-truncate
0202bb2
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: #10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
davidmarkclements@MylesBorins
test: refactor test-https-truncate
5807872
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: #10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.httpsIssues or PRs related to the https subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@davidmarkclements@santigimeno@Trott@cjihrig@mscdex@MylesBorins@addaleax@nodejs-github-bot