Uh oh!
There was an error while loading. Please reload this page.
Closed
Conversation
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`.
mhdawson
commented
Dec 3, 2016
Member
mhdawson
commented
Dec 3, 2016
Member
Once more CI run, think earlier PRs test runs may have left trailing processes on the machines. Cleaned some up and we'll see. |
mhdawson
commented
Dec 3, 2016
Member
Last CI run all green |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: nodejs#10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Trott
commented
Dec 5, 2016
Member
Landed in 1259b88 |
Trott
commented
Dec 5, 2016
Member
Thanks for the contribution! 🎉 |
Fishrock123 pushed a commit
that referenced
this pull request
Dec 5, 2016
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: #10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: nodejs#10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jmdarling pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: nodejs#10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: #10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 28, 2016
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: #10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit
that referenced
this pull request
Jan 23, 2017
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: #10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 24, 2017
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: #10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Feb 1, 2017
Refactored `test-tls-server-verify.js` to replace uses of `var` with `const` and `let`. Also replaced uses of `assert.equal` with `assert.strictEqual`. PR-URL: #10076 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Refactored
test-tls-server-verify.jsto replace uses ofvarwithconstandlet. Also replaced uses ofassert.equalwithassert.strictEqual.