Skip to content

stream, test: add test for _readableState.needReadable - #10241

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:test-need-readable
Closed

stream, test: add test for _readableState.needReadable#10241
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:test-need-readable

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Dec 12, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

stream, test

Description of change

Part of #10230 & #8644, increase coverage of the internal state machine of streams.

@nodejs-github-botnodejs-github-bot added lts-watch-v4.x test Issues and PRs related to the tests. labels Dec 12, 2016
@joyeecheungjoyeecheung changed the title stream, test: Add test for _readableState.needReadable.needReadablestream, test: Add test for _readableState.needReadableDec 12, 2016
@joyeecheungjoyeecheung mentioned this pull request Dec 12, 2016
Closed
@joyeecheungjoyeecheung changed the title stream, test: Add test for _readableState.needReadablestream, test: add test for _readableState.needReadableDec 12, 2016
@mscdexmscdex added the stream Issues and PRs related to the stream subsystem. label Dec 12, 2016
mscdex
mscdex reviewed Dec 12, 2016
View reviewed changes
Comment threadtest/parallel/test-stream-readable-needReadable.js Outdated

@mscdexmscdexDec 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the , 1 here is a typo and should be removed.

@joyeecheungjoyeecheungDec 13, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. That's meant for common.mustCall but I accidentally put it inside the wrong parentheses. The default is 1 anyway so I agree with you, this can be removed.

@joyeecheung

joyeecheung commented Dec 13, 2016

Copy link
Copy Markdown
MemberAuthor

I have removed the misplaced argument to common.mustCall and reworded the comments.

mcollina
mcollina approved these changes Dec 13, 2016
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex

mscdex commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5378/

@mcollina

mcollina commented Dec 13, 2016

Copy link
Copy Markdown
Member

ARM failure unrelated, @mscdex you merge or should I merge?

@joyeecheungjoyeecheung mentioned this pull request Dec 13, 2016
Closed
3 tasks
@joyeecheung

joyeecheung commented Dec 13, 2016

Copy link
Copy Markdown
MemberAuthor

I discovered that the slowProducer example is not covered accurately(pushing is done synchronously). Can I improve this a little bit more?

@mcollina

mcollina commented Dec 13, 2016

Copy link
Copy Markdown
Member

@joyeecheung Sure go ahead.

@joyeecheung

joyeecheung commented Dec 13, 2016

Copy link
Copy Markdown
MemberAuthor

Updates pushed, please take a look @mcollina .

@italoacasasitaloacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@joyeecheung@cjihrig
test: stream readable needReadable state
8806342
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@joyeecheung
joyeecheung deleted the test-need-readable branch January 2, 2017 05:28
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@joyeecheung@MylesBorins
test: stream readable needReadable state
083ff5c
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@joyeecheung@MylesBorins
test: stream readable needReadable state
ba36d55
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@joyeecheung@MylesBorins
test: stream readable needReadable state
2c7a59a
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@joyeecheung@MylesBorins
test: stream readable needReadable state
76b034e
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@joyeecheung@MylesBorins
test: stream readable needReadable state
a24a35f
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@joyeecheung@MylesBorins
test: stream readable needReadable state
135a7c9
PR-URL: #10241
Ref: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@snyk-botsnyk-bot mentioned this pull request Apr 24, 2023
Open
@alisccoaliscco mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 24, 2023
Open
Open
@alisccoaliscco mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 25, 2023
Open
Open
Open
@alisccoaliscco mentioned this pull request Apr 26, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Apr 26, 2023
Open
@alisccoaliscco mentioned this pull request Apr 28, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Apr 28, 2023
Open
@alisccoaliscco mentioned this pull request Apr 29, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
+2 more reviewers
@mscdexmscdexmscdex left review comments
@italoacasasitaloacasasitaloacasas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@mscdex@mcollina@italoacasas@MylesBorins@nodejs-github-bot