Skip to content

stream, test: test for _readableState.emittedReadable - #10249

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:test-emitted-readable
Closed

stream, test: test for _readableState.emittedReadable#10249
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:test-emitted-readable

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Dec 13, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

stream, test

Description of change

Part of #10230, increase coverage of the internal state machine of streams.

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v4.x labels Dec 13, 2016
@joyeecheungjoyeecheung changed the title stream, test: test for _readableState.needReadablestream, test: test for _readableState.emittedReadableDec 13, 2016
@joyeecheung
stream, test: test _readableState.emittedReadable
83e6738
Part of nodejs#10230, increase coverage of the internal
state machine of streams.
@joyeecheung

joyeecheung commented Dec 13, 2016

Copy link
Copy Markdown
MemberAuthor

Sorry, copied the commit message from #10241, should be emittedReadable, not needReadable.

@mscdexmscdex added the stream Issues and PRs related to the stream subsystem. label Dec 13, 2016
@italoacasas

italoacasas commented Dec 13, 2016

Copy link
Copy Markdown

Related to #8683

mcollina
mcollina approved these changes Dec 16, 2016
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina

mcollina commented Dec 16, 2016

Copy link
Copy Markdown
Member

@joyeecheung can you please amend your commit and say that it is part of #8683

@mcollina

mcollina commented Dec 16, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5435/

@mcollina

mcollina commented Dec 16, 2016

Copy link
Copy Markdown
Member

Landing

@mcollina

mcollina commented Dec 16, 2016

Copy link
Copy Markdown
Member

Landed in 8127501.

mcollina pushed a commit that referenced this pull request Dec 16, 2016
@joyeecheung@mcollina
stream, test: test _readableState.emittedReadable
8127501
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
@joyeecheungItalo A. Casas
stream, test: test _readableState.emittedReadable
28ffd59
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@italoacasasitaloacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@joyeecheung@cjihrig
stream, test: test _readableState.emittedReadable
8ddbd53
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joyeecheung
joyeecheung deleted the test-emitted-readable branch January 2, 2017 05:28
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@joyeecheung@MylesBorins
stream, test: test _readableState.emittedReadable
f26213a
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@joyeecheung@MylesBorins
stream, test: test _readableState.emittedReadable
9fa1e7d
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@joyeecheung@MylesBorins
stream, test: test _readableState.emittedReadable
1f6b10d
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@joyeecheung@MylesBorins
stream, test: test _readableState.emittedReadable
a023886
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@joyeecheung@MylesBorins
stream, test: test _readableState.emittedReadable
9a84162
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@joyeecheung@MylesBorins
stream, test: test _readableState.emittedReadable
271f578
Part of #8683, increase coverage of the internal
state machine of streams.
PR-URL: #10249
See: #8683
See: #10230
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@italoacasas@mcollina@mscdex@MylesBorins@nodejs-github-bot