Uh oh!
There was an error while loading. Please reload this page.
test: assert unused vars in test-cli-eval.js - #10759
Closed
StarryShark wants to merge 3 commits into
Closed
Conversation
Trott
reviewed
Jan 12, 2017
| // assert that nothing is written to stdout | ||
| child.exec(nodejs + ' --eval 42', | ||
| function(err, stdout, stderr) { | ||
| assert.strictEqual(err, null); |
Member
There was a problem hiding this comment.
These will work and are totally fine, but it's probably more idiomatic to do this:
assert.ifError(err);Trott
reviewed
Jan 12, 2017
| child.exec(cmd + '42', | ||
| function(err, stdout, stderr) { | ||
| assert.strictEqual(typeof err, 'object'); |
Member
There was a problem hiding this comment.
This is OK, but is probably better like this:
assert(errinstanceofError);Even better if the type of error is known. For example, if it's expected to be a RangeError, then assert.(err instanceof RangeError) etc.
Trott
approved these changes
Jan 12, 2017
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM if CI is green, although if you want to make the changes in the nits I left, even better.
jasnell
approved these changes
Jan 12, 2017
Trott
commented
Jan 12, 2017
Member
Trott
commented
Jan 12, 2017
Member
I suspect that ideally |
StarryShark
commented
Jan 12, 2017
ContributorAuthor
@Trott made a commit to rename |
Trott
commented
Jan 12, 2017
Member
LGTM. Let's run CI again... |
jasnell pushed a commit
that referenced
this pull request
Jan 16, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: #10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Jan 16, 2017
Member
Landed in b9adbf2 |
cjihrig
commented
Jan 16, 2017
Contributor
Looks like this broke the CI on Windows. Fix in #10840. |
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: nodejs#10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: nodejs#10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jan 28, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: #10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: nodejs#10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: nodejs#10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Mar 8, 2017
Contributor
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport If it is backported please include #10840 |
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: #10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: #10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: nodejs/node#10759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert unused variables in test-cli-eval.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test