Skip to content

test: fix broken assertion - #10840

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:broken-test
Closed

test: fix broken assertion#10840
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:broken-test

Conversation

@cjihrig

@cjihrigcjihrig commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

This commit fixes a broken assertion in test-cli-eval.js. b9adbf2 introduced the break, and was landed even though CI showed that the test failed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 16, 2017
@cjihrigcjihrig mentioned this pull request Jan 16, 2017
Closed
3 tasks
@cjihrig

cjihrig commented Jan 16, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/5893/

Trying again: https://ci.nodejs.org/job/node-test-pull-request/5899/

@mscdexmscdex added the process Issues and PRs related to the process subsystem. label Jan 16, 2017
@cjihrig
test: fix broken assertion
013da32
This commit fixes a broken assertion in test-cli-eval.js.
@cjihrig

cjihrig commented Jan 16, 2017

Copy link
Copy Markdown
ContributorAuthor

CI is green. May want to fast track this to unbreak the CI.

@italoacasas

italoacasas commented Jan 16, 2017

Copy link
Copy Markdown

+1 for fast tracking this

addaleax
addaleax approved these changes Jan 17, 2017
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, landing

@addaleax

addaleax commented Jan 17, 2017

Copy link
Copy Markdown
Member

Landed in 38ae95b

addaleax pushed a commit that referenced this pull request Jan 17, 2017
@cjihrig@addaleax
test: fix broken assertion
38ae95b
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: #10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

jasnell commented Jan 17, 2017

Copy link
Copy Markdown
Member

btw, my apologies on this. I'd completely missed the breakage there somehow.

@cjihrig
cjihrig deleted the broken-test branch January 17, 2017 02:13
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@cjihrigItalo A. Casas
test: fix broken assertion
46575e2
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: nodejs#10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jan 28, 2017
@cjihrig@targos
test: fix broken assertion
63fa05d
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: #10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@italoacasasitaloacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrigItalo A. Casas
test: fix broken assertion
32da59a
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: nodejs#10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrigItalo A. Casas
test: fix broken assertion
afd80d4
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: nodejs#10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@cjihrig@MylesBorins
test: fix broken assertion
1a05f4a
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: #10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@cjihrig@MylesBorins
test: fix broken assertion
b6c30e1
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: #10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@cjihrig@andrew749
test: fix broken assertion
fb59cda
This commit fixes a broken assertion in test-cli-eval.js.
PR-URL: nodejs/node#10840
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@italoacasasitaloacasasitaloacasas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

processIssues and PRs related to the process subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjihrig@italoacasas@addaleax@jasnell@mscdex@MylesBorins@targos@nodejs-github-bot