Skip to content

test: simplify WPT.assert_throws() - #11126

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:chewbacca
Closed

test: simplify WPT.assert_throws()#11126
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:chewbacca

Conversation

@Trott

@TrottTrott commented Feb 2, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test url

@TrottTrott added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 2, 2017
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2017
@Trott

Trott commented Feb 2, 2017

Copy link
Copy Markdown
MemberAuthor

/cc @joyeecheung in case there is a subtlety I am missing

@Trott

Trott commented Feb 2, 2017

Copy link
Copy Markdown
MemberAuthor

Hmmm...oh, I think I see, this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?

@Trott

Trott commented Feb 2, 2017

Copy link
Copy Markdown
MemberAuthor

(Aside: It would be great if common.WPT could be documented in the test/README.md where the common module API is documented.)

@TimothyGu

Copy link
Copy Markdown
Member

this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?

Yeah, making this kind of subtle changes makes importing tests more difficult. Check out @joyeecheung's explanation (#11079 (comment)) for how WPTs are imported.

@Trott

Trott commented Feb 2, 2017

Copy link
Copy Markdown
MemberAuthor

(Minimal doc stub for common.WPT here: #11127 If someone wants to do something more complete and informative, by all means, close that PR and open a better one.)

@Trott

Trott commented Feb 2, 2017

Copy link
Copy Markdown
MemberAuthor

OK, makes sense to me. I'll close this.

@TrottTrott closed this Feb 2, 2017
@Trott
Trott deleted the chewbacca branch January 13, 2022 22:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott@TimothyGu@nodejs-github-bot