Uh oh!
There was an error while loading. Please reload this page.
doc: add common.WPT to test README - #11127
Conversation
Trott
commented
Feb 2, 2017
(This documentation is a stub.) |
There was a problem hiding this comment.
A link would be helpful (Web Platform Tests and/or testharness.js). Also the second sentence seems to have an extra "in".
TimothyGu
commented
Feb 2, 2017
I personally don't really think it's necessary to extend this documentation stub, when |
Trott
commented
Feb 2, 2017
@TimothyGu Thanks. I incorporated both links and got a little more specific with the text. PTAL. |
TimothyGu
left a comment
There was a problem hiding this comment.
LGTM. Thanks for writing this.
There was a problem hiding this comment.
I would say it's more like a "mock" or "port"? But this description LGTM too.
There was a problem hiding this comment.
"port" works for me. I'll change it.
d28ea8c to
c284e24CompareThere was a problem hiding this comment.
Maybe ### WPT (Web Platform Tests) for people who don't know what it is and don't see the link two lines down?
There was a problem hiding this comment.
Parentheses are used to show arguments in the other entries so I probably wouldn't do it exactly that way. But if there's a way to clarify it in the text below, I'm happy to.
There was a problem hiding this comment.
Maybe just start the next line with it, something like:
Web Platform Tests - A port of parts of
There was a problem hiding this comment.
PR-URL: nodejs#11127 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Feb 6, 2017
Landed in 3fffebb |
PR-URL: #11127 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#11127 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#11127 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
doc test