Uh oh!
There was an error while loading. Please reload this page.
test: improve console coverage to check ignoreErrors - #11531
Closed
yoichi-watanabe wants to merge 1 commit into
Closed
test: improve console coverage to check ignoreErrors#11531yoichi-watanabe wants to merge 1 commit into
yoichi-watanabe wants to merge 1 commit into
Conversation
Trott
commented
Feb 24, 2017
Member
@nodejs/testing |
cjihrig
requested changes
Feb 24, 2017
| const { Writable } = require('stream'); | ||
| const assert = require('assert'); | ||
| const ignoreErrors = false; | ||
| const expected = 'foobarbaz'; |
Contributor
There was a problem hiding this comment.
Could you either scope this to the first test, or name it something else. This isn't actually "expected" output in the second test.
3 tasks
| }); | ||
| const c = new Console(err, err, ignoreErrors); | ||
| c.log(expected); | ||
| }, /^Error: foobar$/); No newline at end of file |
Contributor
There was a problem hiding this comment.
Our linter will fail as there is no newline at the end of the file.
| assert.throws(() => { | ||
| const err = new Writable({ | ||
| write: common.mustCall((chunk, enc, callback) => { |
jasnell
commented
Mar 17, 2017
Member
ping @chipstar :-) |
BridgeAR
commented
Aug 26, 2017
Member
Ping @yoichi-watanabe |
BridgeAR
commented
Sep 12, 2017
Member
Closing due to long inactivity. @yoichi-watanabe please feel free to leave a comment to open this PR again if you want to follow up on it or just open a new PR. I am sorry that your PR could not land as is and your work is much appreciated nevertheless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can cover some uncovered lines on
lib/console.js.see:https://coverage.nodejs.org/coverage-29ff16f04373d434/root/console.js.html
I checked
writefunction if ignoreErrors is false.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test